Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add graffiti to parametrized wall palette #77952

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Milopetilo
Copy link
Contributor

Summary

Content "Walls now have a chance of having graffiti on them"

Purpose of change

Was lurking about the discord recently and saw someone bring up the fact that only vandalized buildings have graffiti on them even though there were riots and people generally behaving unwise weeks prior to game start. This makes it so that there sometimes is graffiti on all walls.

Describe the solution

Add nests to parametrized_walls_palette to have graffiti spawn, I've chosen to copy over the nests from standard_domestic_damage_large_palette which has a chance of 1/300 per wall tile, which comes down to ~1 in 3 buildings to have a piece of graffiti on them. This may be too low but I'd rather have too little than too much.

Describe alternatives you've considered

Make a new palette for ungraffitied walls and make the normal walls include graffiti, is still very easily possible if needed.

Testing

Game loads, walls have graffiti every now and then.

Additional context

I've elected to not touch inner walls since that will lead to graffiti being inside buildings that are fully locked sometimes. I've not added it to the highrise walls palette because those walls are high and usually unreachable.

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions labels Nov 17, 2024
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant