-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MoM] Update creature mindsight to be variable, apply to Eater #77963
Open
Standing-Storm
wants to merge
9
commits into
CleverRaven:master
Choose a base branch
from
Standing-Storm:mindsight-eater
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+97
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
<Documentation>
Design documents, internal info, guides and help.
[JSON]
Changes (can be) made in JSON
[C++]
Changes (can be) made in C++. Previously named `Code`
Monsters
Monsters both friendly and unfriendly.
[Markdown]
Markdown issues and PRs
Mods
Issues related to mods or modding
labels
Nov 18, 2024
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions
bot
added
json-styled
JSON lint passed, label assigned by github actions
astyled
astyled PR, label is assigned by github actions
and removed
astyled
astyled PR, label is assigned by github actions
labels
Nov 18, 2024
github-actions
bot
added
Mechanics: Enchantments / Spells
Enchantments and spells
Mods: Mind Over Matter
astyled
astyled PR, label is assigned by github actions
labels
Nov 18, 2024
Spell checker encountered unrecognized words in the in-game text added in this pull request. See below for details. Click to expand
This alert is automatically generated. You can simply disregard if this is inaccurate, or (optionally) you can also add the new words to Hints for adding a new word to the dictionary
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
astyled
astyled PR, label is assigned by github actions
[C++]
Changes (can be) made in C++. Previously named `Code`
<Documentation>
Design documents, internal info, guides and help.
[JSON]
Changes (can be) made in JSON
json-styled
JSON lint passed, label assigned by github actions
[Markdown]
Markdown issues and PRs
Mechanics: Enchantments / Spells
Enchantments and spells
Mods: Mind Over Matter
Mods
Issues related to mods or modding
Monsters
Monsters both friendly and unfriendly.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Mods "[MoM] Update creature mindsight to be variable, apply to Eater"
Purpose of change
Hardcoding creature mindsight as 2/3rds of daytime vision range isn't very flexible. It'd be nice to have ways for mindsight to be greater than normal vision range, for some kind telepathic predator that specifically looks for sentient prey.
Like, say, an Eater.
Plus this should let me do enough to #73628 to get it merged.
Describe the solution
Change the MIND_SEEING flag so the base range is 5 squares. Add a series of hardcoded effects that increase the range by 5, 10, 20, and 30. These effects all stack, so with a combination it should be possible to get any necessary mindsight range out to the limit of the reality bubble.
Set the Eater's normal vision range to 3, but give it 35 mindsight (5 + 30 effect). The eaters are:
Spoiler
The feeding organs of an extradimensional predator taking advantage of the Cataclysm to look for prey, and I like the idea that it's much easier for them to hone in on minds than it is to spot life in general.
Give the hidebehind mindsight of 25 (base 5 + effect 20).
Describe alternatives you've considered
Testing
Eater and hidebehind both affect the appropriate effect as soon as they can. Doing so allows them to see you through mindsight. If you turn on Telepathic Shield or use the Telepathic Dampener, you are invisible to them.
Bug #77436 means you can see them turning on them mindsight, but it cannot be helped.
This does mean Eaters can attack you through walls, which might need further balancing (maybe a range reduction, or just requiring no obstacles in between).
Additional context
I left comments in the monster files listing the range of their mindsight, so it's obvious.
I'd love to let Eaters phase through walls, but that's currently beyond my abilities.