Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix enchantment #78739

Merged
merged 2 commits into from
Dec 24, 2024
Merged

Fix enchantment #78739

merged 2 commits into from
Dec 24, 2024

Conversation

osuphobia
Copy link
Contributor

@osuphobia osuphobia commented Dec 23, 2024

Summary

Bugfixes "Fix enchantment"

Purpose of change

Fix #78735
Fix CI monster_throwing_sanity_test failure

Describe the solution

Fix enchant_cache::clear().

Describe alternatives you've considered

Use

enchant_cache tmp;
*enchantment_cache = tmp;

Testing

monster_throwing_sanity_test passed.
Tested rm13, phase immersion suit, and bio_night, all worked as expected.

Additional context

The old initial process

*enchantment_cache = inv->get_active_enchantment_cache( *this )

is equal to

enchant_cache tmp;
*enchantment_cache = tmp;

🤔
Maybe I can write a test case in another PR.

@github-actions github-actions bot added Code: Tests Measurement, self-control, statistics, balancing. [C++] Changes (can be) made in C++. Previously named `Code` Monsters Monsters both friendly and unfriendly. Mechanics: Enchantments / Spells Enchantments and spells labels Dec 23, 2024
@github-actions github-actions bot requested a review from KorGgenT December 23, 2024 13:22
@github-actions github-actions bot added <Bugfix> This is a fix for a bug (or closes open issue) astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions labels Dec 23, 2024
@osuphobia osuphobia force-pushed the Fix_enchantment branch 3 times, most recently from 9b12f30 to 6266b96 Compare December 23, 2024 16:43
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Dec 24, 2024
@Maleclypse Maleclypse merged commit 44b3817 into CleverRaven:master Dec 24, 2024
25 of 26 checks passed
@osuphobia osuphobia deleted the Fix_enchantment branch December 24, 2024 05:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions <Bugfix> This is a fix for a bug (or closes open issue) [C++] Changes (can be) made in C++. Previously named `Code` Code: Tests Measurement, self-control, statistics, balancing. json-styled JSON lint passed, label assigned by github actions Mechanics: Enchantments / Spells Enchantments and spells Monsters Monsters both friendly and unfriendly.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Effects from equipment are spammed
2 participants