Match ImGui inherit_base_colors

[alef]

Summary

Interface "Match ImGui inherit_base_colors"

Purpose of change

I started using imgui_style.json:inherit_base_colors = true, but the UI colors didn't match so I changed the three you see in the commit. Here is the main menu loading a world.
Before ... :

... and after :

Describe the solution

Describe alternatives you've considered

Testing

Settings "inherit_base_colors" to true in the file imgui_style.json.

Additional context

[db48x]

Although I applaud the initiative, I request that you not make this specific change. The titlebar of a window should not be black; it should be some color that contrasts with the window background (which is black).

If you want to match the look of the old window in this case, just modify the code in main_menu.cpp so that it doesn’t give the window a title at all. Like this:

@@ -1254,7 +1254,7 @@ bool main_menu::load_character_tab( const std::string &worldname )
     }
 
     uilist mmenu;
-    mmenu.title = string_format( _( "Load character from \"%s\"" ), worldname );
+    mmenu.text = string_format( _( "Load character from \"%s\"" ), worldname );
     mmenu.border_color = c_white;
     int opt_val = 0;
     for( const save_t &s : savegames ) {

[Kilvoctu]

The titlebar of a window should not be black; it should be some color that contrasts with the window background (which is black).

Are there any places in which this would cause problem?
I tried this change on my fork and checked a number of affected pop-ups (missions, notes, item info, etc.). In each case, I felt overall it looked better; more consistent with the rest of the UI and historical CDDA aesthetic.

[Brambor]

Somewhat related issues:

• Nested groups are hard to see since #60683 #62501
• Change nested recipes colour to something readable #73949

The problem is just choosing pleasant colours.

[db48x]

Are there any places in which this would cause problem?

Titlebars are an important user control even though we cannot fully use them at the moment. Generally they allow the user to drag the window to reposition it. We’ve temporarily disabled that because it confuses the code that handles mouse clicks, but eventually I want that to work correctly. Therefore we should not make titlebars invisible. If you think it is important that this window look exactly like the old window, then remove the titlebar instead of making the titlebar invisible.

[GuardianDll]

Can you rebase it please?