Set disassembly range to PICKUP_RANGE: 6

[Brambor]

Summary

Balance "Set disassembly range to crafting range: 6"

Purpose of change

• Conceptually and eventually, disassembly should be like crafting. Setting them to have same range makes sense.
• Standing on the central crafting spot in your base (you already have) you can disassemble things from there too now.

Describe the solution

• Increase the range in the ( disassembly menu to PICKUP_RANGE, which is 6.
  - [ ] Toggle between 1 and 6 for @moxian.
  • Hopefully I will do that tomorow.
  • Edit: see Set disassembly range to PICKUP_RANGE: 6 #78748 (comment)

Describe alternatives you've considered

My only concern was:

Wouldn't it be weird if you could essentially destroy any disassemable item distant 6 tiles? If an enemy NPC drops a gun, you could just destroy it, right? Or is this not an issue?

from #78737 (comment)

But now that I think about it, this exploit is a tiny bit more effective thanks to the range increase from 1 to 6, but it was always there and it is not a blocker.

• In Disassembly menu: highlight filtered components, always show required & components #78737 I wanted to expand what the disassembly menu shows to the whole bubble so that players see items further than 1 tile. See the PR for more arguments and discussion on that. This PR replaces that QoL improvement in that PR completely and all the display shenanigans around.
• Instead of the item teleporting, avatar could walk to the item and retrieves it somehow. Maybe when crafting does that too.

Testing

1. Open the menu.
2. Select an item that is 3N (switch to ; hierarchy to see the distances).
3. Disassembly starts in your hand / on a workbench next to you.
4. Canceling leaves the partially disassembled item where it is (your hand or the workbench).
5. Finishing the disassembly works as expected too.

Additional context

[moxian]

Great idea but range 6 is way too much, from practical standpoint. I don't want to see aalllllllll the junk in my house when I'm pressing the button - I would not be remotely able to navigate that. I don't want to accidentally disassemble a thing in the "wrong" pile, and lose track of it (i.e. disassembly my backpack in the "here's my raiding equipment" pile instead of "here's my raided loot pile").

Please make it range 2 (i.e. the current tile+immediately adjacent ones). It would solve the current annoyances of needing to climb up your crafting bench in order to disassemble things there, but without overwhelming the UI, and without the potential exploits you mention.
(I can maaaaybe buy one extra range beyond that (maybe), but anything after definitely brings more harm than good.)

P.s: the comparison to crafting does not quite work, because when crafting you usually destroy "useless" components to create "useful" ones, whereas with disassembling you destroy the "kinda useful" ones, so you need to be more picky.
And to be clear, I have pretty much no qualms with having range 6 mechanically - I'm only really worried about the UI (and I'm afraid #78737 would not be quite enough to address that)

P.p.s.: Range 6 would make "disassemble everything once" option completely useless (although it might not be a big deal, since it's already not used much)

P3s: I can also get behind range6 if it was a conditional toggle

[Brambor]

Great idea but range 6 is way too much, from practical standpoint. I don't want to see aalllllllll the junk in my house when I'm pressing the button - I would not be remotely able to navigate that. I don't want to accidentally disassemble a thing in the "wrong" pile, and lose track of it (i.e. disassembly my backpack in the "here's my raiding equipment" pile instead of "here's my raided loot pile").

P3s: I can also get behind range6 if it was a conditional toggle

I think I could satisfy you with a toggle: "items next to you"/"items from crafting range". Oh, I see PS3.

I think one toggle could be allowed in this menu. I will try.

P.s: the comparison to crafting does not quite work, because when crafting you usually destroy "useless" components to create "useful" ones, whereas with disassembling you destroy the "kinda useful" ones, so you need to be more picky. And to be clear, I have pretty much no qualms with having range 6 mechanically - I'm only really worried about the UI (and I'm afraid #78737 would not be quite enough to address that)

As long as we stand on the same side from mechanical/exploit side. We can discuss the UI separately.

P.p.s.: Range 6 would make "disassemble everything once" option completely useless (although it might not be a big deal, since it's already not used much)

I think you are talking about this menu:

Which this doesn't touch at all.

The menu I am talking about:

Doesn't have such option.

[moxian]

TIL there's a third way to disassemble things that I didn't know existed. (Yes i was talking about the (B)utcher list)

So, uhm, okay. This newfound menu is great and seems to do exactly what I want it to do.
I still maintain that changing it to range 6 would make it much less useful than it is right now, but if that functionality is hidden beside the toggle, then I have no reason to complain.

Thanks for showing me the tech! ❤️

[Brambor]

@moxian I changed my mind. While it is possible to implement the toggle in a way that would be a bit faster for those who only show items that are 1 tile away, I don't think it is the right thing to do. Just as you don't craft from items only 1 block away.

• A person can always switch to ; hierarchy to see how far the item is.
• It would require more code (to maintain).