Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix duplicate integrated armor #78762

Merged
merged 1 commit into from
Dec 26, 2024
Merged

fix duplicate integrated armor #78762

merged 1 commit into from
Dec 26, 2024

Conversation

osuphobia
Copy link
Contributor

Summary

Bugfixes "fix duplicate integrated armor"

Purpose of change

Fix #78761

Describe the solution

I accidentally‌ put mutation_loss_effect( trait ) in the if conditional, move it out.
Now character lose the integrated armors provided by mutations when they got removed.

Describe alternatives you've considered

Testing

Load the sav in the issue, toggle the Gnarled Claws, works as expected.

Additional context

@github-actions github-actions bot added Mutations / Traits / Professions/ Hobbies Mutations / Traits / Professions/ Hobbies [C++] Changes (can be) made in C++. Previously named `Code` <Bugfix> This is a fix for a bug (or closes open issue) astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Dec 25, 2024
@Maleclypse Maleclypse merged commit 786f157 into CleverRaven:master Dec 26, 2024
23 of 27 checks passed
@osuphobia osuphobia deleted the Fix-Integrated-armor branch December 30, 2024 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions <Bugfix> This is a fix for a bug (or closes open issue) [C++] Changes (can be) made in C++. Previously named `Code` json-styled JSON lint passed, label assigned by github actions Mutations / Traits / Professions/ Hobbies Mutations / Traits / Professions/ Hobbies
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Integrated armor provided by mutations remain even after the associated mutation disapears
2 participants
@osuphobia @Maleclypse