Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand and use cataimgui scrolling function #78763

Merged
merged 1 commit into from
Dec 26, 2024

Conversation

ZhilkinSerg
Copy link
Contributor

@ZhilkinSerg ZhilkinSerg commented Dec 25, 2024

Summary

None

Purpose of change

Expand and use cataimgui scrolling function.

Describe the solution

  1. Added possibility to scroll to the beginning (HOME) and end (END) of the window in addition to existing line (UP and DOWN) and page scrolling (PAGE UP and PAGE DOWN).
  2. Utilize scroll function in migrated menus:
  • martial arts details;
  • missions;
  • scores;
  • item compare;
  • item info.

Testing

Make sure scrolling works in martial arts details, missions, scores, item compare and item info menus.

@github-actions github-actions bot added Info / User Interface Game - player communication, menus, etc. Missions Quests and missions [C++] Changes (can be) made in C++. Previously named `Code` Game: Achievements / Conducts / Scores Player goals and how they are tracked. Martial Arts Arts, Techniques, weapons and anything touching martial arts. astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Dec 25, 2024
@Brambor
Copy link
Contributor

Brambor commented Dec 26, 2024

Could you / does this look into the pocket settings menu as well?

@Maleclypse Maleclypse merged commit 9a0d234 into CleverRaven:master Dec 26, 2024
23 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [C++] Changes (can be) made in C++. Previously named `Code` Game: Achievements / Conducts / Scores Player goals and how they are tracked. Info / User Interface Game - player communication, menus, etc. json-styled JSON lint passed, label assigned by github actions Martial Arts Arts, Techniques, weapons and anything touching martial arts. Missions Quests and missions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants