-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add imgui demo to the debug menu #78771
base: master
Are you sure you want to change the base?
Conversation
Instead of duplicating it, you should put the class in a header. |
Reasonable. But which one? Neither including |
A new file is fine, yeah. |
#include "translations.h" | ||
|
||
|
||
debug_imgui_demo_ui::debug_imgui_demo_ui() : |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's preferable to keep the name imgui_demo
over changing it to debug_imgui_demo
.
(Just making sure the name change isn't merged, maybe you knew already.)
Summary
Infrastructure "Added Imgui demo screen (and style editor) to the debug menu"
Purpose of change
Breaking the UI without the need to recompile and/or painstalkingly step line-by-line with a debugger trying to figure out why is my text clipping ever so slightly.
Describe the solution
Shamelessly copy-paste the imgui demo code on the main menu screen into the debug_menu.cpp (without the lorem ipsum window from the former)
Describe alternatives you've considered
Adding it to the global hotkeys so that I can invoke it while having another imgui menu open, but I'm hesitant to pollute global hotkeys with functionality that's exclusively useful for debug purposes. (I'm also not 100% sure it will even re-draw the "other" imgui windows that way, so the point is moot. But i haven't tried either)
Testing
Yes, that's kinda the point.
Additional context