[XEDRA] Adjust dream magic xp requirements to jmath

[b3brodie]

Summary

Mods "[XEDRA] Adjust dream magic XP requirements to jmath"

Purpose of change

Currently dream magic uses EOCs to reduce the amount of effort required to level the spells. This approach does lead to some strangeness that I feel adjusting the xp formulas would fix.

• Faulty communication of xp gains / requirements: The current EOC makes each spell, on average, take a couple of casts to level regardless of its actual level. However, to the player they will see that the next level requires thousands to tens of thousands of xp to level in the magic window, while their log will be telling them they are only getting a hundred xp per cast.
• 'Low' max level. This likely wouldn't be an issue with XEDRA alone, but with multiple mods characters could conceivably reach the max spell level as defined by the integer limit of XP for dream classes. If they do so, their spell xp would loop back around and break their spell level. Reducing the actual xp requirements will make this a non-issue by massively raising the xp-defined max level.

Describe the solution

Dream Magic Adjustments:

• Spells level in 3 casts, with 100 xp gained per cast and 300 xp required to level
• Failed spell casts cost 10% of mana cost
• Failed spells give 100% of normal exp to help move past the "very hard to cast at low levels" phase.
• Spells cannot be level past 0 with the artifacts.

Adjust the spell xp formulas using the magic_type

• A character with 100 focus and 8 int gets about 90 xp per cast, so 300 xp per level = 3 casts to level each spell

Add max_book_level field to magic type and individual spell definitions.

• Takes an int which defines what the max level of this spell type / spell is learnable via books, scrolls, etc.

Add casting_xp_formula_id to magic type

• Takes a jmath_func which calculates how much xp is given for casting a spell.

Add failure_cost_percent to magic type

• Takes a double or math function that evaluates to one. On spell cast failure, it will use this percent to calculate how much energy will be used. Defaults to 0. Values above 1 and below 0 are valid, but spells with a failure cost greater than the success cost will use the success cost to calculate castability.

add failure_exp_percent to magic type

• Takes a double or math function that evaluates to one. Determines what percent of normal spell xp one will gain for failing to cast a spell. Defaults to 0.2 which was the value before adding this change.

Add failure_eocs to magic type

• Accepts eoc ids that will run when a character fails to cast a spell successfully.

Also give the adjusted xp formulas to inventor and dreamsmith since they're also 'dream' magic.

Describe alternatives you've considered

Different exp costs to level. I felt that 3 casts per level was a nice average from the prior numbers though.
Different numbers for the other new values, like failure cost. These numbers are fairly arbitrary.
Splitting eater and dreamer/inventor/dreamsmith xp requirements since eater spells tend to be more costly

Testing

Everything compiled, etc.
Saw that the spells formulas are adjusted as intended
Saw that artifacts were not usable past 0
Saw that xp was still 100 even at spell fail
Saw that some mana was still consumed even on spell failure.
Added the ethereal wings initiate eoc to test and saw that spell failures toggled the wings.

Additional context

For existing saves, this PR would permanently max out pretty much any already learned dream magic spells since they'd still have the same xp which is then calculated with the new formulas. However, leveling the spells was already pretty easy so its likely that most are already pretty close to max level. I don't think that this is too much of an issue.

[GuardianDll]

FYI the idea is that dream magic cannot be learned from books, but there are few more underlying issues with it, like difficulty field makes it impossible for low lvl caster to cast a spell any reliably (probably can be fixed nowadays by moving difficulty formula to magic type), and approach of "you train spells when you cast them" incentivizes people to just abuse spells that do not need a target, keybinding it and then just repeating spell casting over and over and over

side note, there was #78665, so i suspect some magic mods may want to have fail_effect defined in magic type

[b3brodie]

FYI the idea is that dream magic cannot be learned from books, but there are few more underlying issues with it, like difficulty field makes it impossible for low lvl caster to cast a spell any reliably (probably can be fixed nowadays by moving difficulty formula to magic type), and approach of "you train spells when you cast them" incentivizes people to just abuse spells that do not need a target, keybinding it and then just repeating spell casting over and over and over

side note, there was #78665, so i suspect some magic mods may want to have fail_effect defined in magic type

I can expand the magic_type field in this PR to add some extra things such as fail cost + plus maybe a fail EOC and difficulty formula. I don't have any good ideas for the repeatedly casting spells on yourself over and over again though, unfortunately.

[GuardianDll]

That's an issues of xedra dream magic design, it's not something you can, or need, to solve, worry not

[Standing-Storm]

maybe a fail EOC

Sinister laughter echoes in the distance

I don't have any good ideas for the repeatedly casting spells on yourself over and over again though, unfortunately.

If it is at all possible to grind, regardless of how tedious it is, people will do it. We haven't solved that in 50 years of video game design (other than designing games that have no improvable stats), and it's probably not solvable.

[Standing-Storm]

I can expand the magic_type field in this PR to add some extra things such as fail cost + plus maybe a fail EOC and difficulty formula. I don't have any good ideas for the repeatedly casting spells on yourself over and over again though, unfortunately.

I understand if this is out of scope, but maybe JSONifying the exp-granted-per-cast formula would be a way to solve this?

I admit this is a selfish request, though, because I want to adjust it for MoM psionics (so you get more if your Nether Attunement is higher).

[b3brodie]

Alright, I think something went wrong with my conflict fix which broke the labeling, but the actual PR content is fully functional