Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev: help: Support '--help' option for cluster properties #1643

Merged

Conversation

liangxin1300
Copy link
Collaborator

@liangxin1300 liangxin1300 commented Dec 25, 2024

By using crm configure property <property_name> --help, print the help of property on non-interactive mode.

Also, for crm configure property command, print all properties if no property is specified

Copy link

codecov bot commented Dec 25, 2024

Codecov Report

Attention: Patch coverage is 29.41176% with 12 lines in your changes missing coverage. Please review.

Project coverage is 69.72%. Comparing base (66a75d1) to head (7ceabf7).
Report is 4 commits behind head on master.

Files with missing lines Patch % Lines
crmsh/help.py 16.66% 10 Missing ⚠️
crmsh/ui_configure.py 33.33% 2 Missing ⚠️
Additional details and impacted files
Flag Coverage Δ
integration 53.54% <29.41%> (-0.02%) ⬇️
unit 53.08% <11.76%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
crmsh/command.py 62.50% <100.00%> (+0.13%) ⬆️
crmsh/ui_configure.py 45.05% <33.33%> (-0.05%) ⬇️
crmsh/help.py 86.03% <16.66%> (-2.82%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@liangxin1300 liangxin1300 marked this pull request as ready for review December 25, 2024 08:09
…860)

By using `crm configure property <property> --help`, print the help of
property on non-interactive mode.
@liangxin1300 liangxin1300 force-pushed the 20241225_cluster_property branch from 9121e7b to 7106039 Compare December 29, 2024 14:02
Copy link
Contributor

@zzhou1 zzhou1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

To mention if no property is specified, all properties will be printed.
Also, add a note to mention that use --help to print help text for each
property.
@liangxin1300 liangxin1300 force-pushed the 20241225_cluster_property branch from 7106039 to 7ceabf7 Compare December 30, 2024 02:43
@liangxin1300 liangxin1300 merged commit aae750f into ClusterLabs:master Dec 30, 2024
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants