Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Ubuntu oval and remediation for nftables_rules_permanent #12643

Merged
merged 1 commit into from
Nov 28, 2024

Conversation

mpurg
Copy link
Contributor

@mpurg mpurg commented Nov 27, 2024

Description:

  • Remove Ubuntu oval and remediation for nftables_rules_permanent

Rationale:

  • Existing ubuntu OVAL checks only whether configuration files are
    included in /etc/nftables.conf, and whether they are not empty.
    It doesn't check for actual contents, giving a false sense of
    correctness when the check passes.
  • The Ubuntu CIS recommendations require that the content matches
    local site policy, which is not possible to automate, thus
    removing the audit and remediation.

Existing ubuntu OVAL checks only whether configuration files are
included in /etc/nftables.conf, and whether they are not empty.
It doesn't check for actual contents, giving a false sense of
correctness when the check passes.

The Ubuntu CIS recommendations require that the content matches
local site policy, which is not possible to automate, thus
removing the audit and remediation.
@openshift-ci openshift-ci bot added the needs-ok-to-test Used by openshift-ci bot. label Nov 27, 2024
Copy link

openshift-ci bot commented Nov 27, 2024

Hi @mpurg. Thanks for your PR.

I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

Copy link

codeclimate bot commented Nov 27, 2024

Code Climate has analyzed commit 5a1fb41 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 60.9% (0.0% change).

View more on Code Climate.

@jan-cerny jan-cerny added this to the 0.1.76 milestone Nov 28, 2024
@jan-cerny jan-cerny self-assigned this Nov 28, 2024
@jan-cerny jan-cerny added the Ubuntu Ubuntu product related. label Nov 28, 2024
@jan-cerny jan-cerny merged commit cfa2a1b into ComplianceAsCode:master Nov 28, 2024
94 of 96 checks passed
@dodys
Copy link
Contributor

dodys commented Nov 28, 2024

@jan-cerny we will revert this. It shouldn't have been merged since this is still automated according to CIS and any change to it should be discussed with them previously. Therefore removing this experience from users, specially those running 20.04 or 22.04 is not worth it right now, until then we should keep as-is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-ok-to-test Used by openshift-ci bot. Ubuntu Ubuntu product related.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants