Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ensure IsActive column does not re-activate #172

Merged
merged 7 commits into from
Oct 16, 2024

Conversation

ivokub
Copy link
Contributor

@ivokub ivokub commented Oct 10, 2024

This PR fixes Issue H in the LA audit report.

For the precompile glue modules we have the IsActive column indicating if the current row is actual computation row or padding to ensure that the column is padded up to power of two length. When the rows are padding rows then we expect that the rest of the columns are zero in the same row.

This PR enforces that the IsActive column can not go from 0 to 1 (deactivated->activated), causing possible soundness issues. Furthermore, started using the common_constraints package for better modularity.

Checklist

  • I wrote new tests for my new core changes.
  • I have successfully ran tests, style checker and build against my new changes locally.
  • I have informed the team of any breaking changes if there are any.

@ivokub ivokub added bug Something isn't working Prover Tag to use for all work impacting the prover labels Oct 10, 2024
@ivokub ivokub self-assigned this Oct 10, 2024
@codecov-commenter
Copy link

codecov-commenter commented Oct 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.39%. Comparing base (215b60c) to head (a458249).

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #172      +/-   ##
============================================
+ Coverage     70.38%   70.39%   +0.01%     
  Complexity     1040     1040              
============================================
  Files           282      282              
  Lines         11314    11312       -2     
  Branches       1082     1082              
============================================
  Hits           7963     7963              
- Misses         2880     2882       +2     
+ Partials        471      467       -4     
Flag Coverage Δ *Carryforward flag
hardhat 98.70% <ø> (ø)
kotlin 67.87% <ø> (+0.01%) ⬆️ Carriedforward from e1b956c

*This pull request uses carry forward flags. Click here to find out more.

see 4 files with indirect coverage changes

@ivokub ivokub merged commit 9763bf2 into main Oct 16, 2024
13 of 14 checks passed
@ivokub ivokub deleted the fix/audit-la-h-isactive-activation branch October 16, 2024 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Prover Tag to use for all work impacting the prover
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants