log plugin name at registration; remove override of getName() method #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sally MacFarlane <[email protected]>
Draft
macfarla
commented
Oct 14, 2024
| log.info( | ||
| "Registering Linea plugin of type {} with name {}", | ||
| this.getClass().getName(), | ||
| this.getName()); |
There was a problem hiding this comment.
if plugin name == class name this extra logging is not needed
fab-10
approved these changes
Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
unique plugin names are required for identification purposes. These plugins were all named "linea" which made it impossible to differentiate between them using name.
when calling
plugins_reloadPluginConfigthe name specified must match the getName() value so it must be unique for this function to be available.