Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

log plugin name at registration; remove override of getName() method #99

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

log plugin name at registration; remove override of getName() method #99

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion sequencer/src/main/java/net/consensys/linea/AbstractLineaRequiredPlugin.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,10 @@ public abstract class AbstractLineaRequiredPlugin extends AbstractLineaPrivateOp
public void register(final BesuContext context) {
super.register(context);
try {
log.info("Registering Linea plugin {}", this.getClass().getName());
log.info(
"Registering Linea plugin of type {} with name {}",
this.getClass().getName(),
this.getName());
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if plugin name == class name this extra logging is not needed


blockchainService =
context
Expand Down
8 changes: 0 additions & 8 deletions sequencer/src/main/java/net/consensys/linea/extradata/LineaExtraDataPlugin.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,6 @@

package net.consensys.linea.extradata;

import java.util.Optional;

import com.google.auto.service.AutoService;
import lombok.extern.slf4j.Slf4j;
import net.consensys.linea.AbstractLineaRequiredPlugin;
Expand All @@ -29,15 +27,9 @@
@Slf4j
@AutoService(BesuPlugin.class)
public class LineaExtraDataPlugin extends AbstractLineaRequiredPlugin {
public static final String NAME = "linea";
private BesuContext besuContext;
private RpcEndpointService rpcEndpointService;

@Override
public Optional<String> getName() {
return Optional.of(NAME);
}

@Override
public void doRegister(final BesuContext context) {
besuContext = context;
Expand Down
6 changes: 0 additions & 6 deletions ...a/net/consensys/linea/sequencer/txpoolvalidation/LineaTransactionPoolValidatorPlugin.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,17 +46,11 @@
@Slf4j
@AutoService(BesuPlugin.class)
public class LineaTransactionPoolValidatorPlugin extends AbstractLineaRequiredPlugin {
public static final String NAME = "linea";
private BesuConfiguration besuConfiguration;
private TransactionPoolValidatorService transactionPoolValidatorService;
private TransactionSimulationService transactionSimulationService;
private Optional<JsonRpcManager> rejectedTxJsonRpcManager = Optional.empty();

@Override
public Optional<String> getName() {
return Optional.of(NAME);
}

@Override
public void doRegister(final BesuContext context) {
besuConfiguration =
Expand Down
6 changes: 0 additions & 6 deletions ...c/main/java/net/consensys/linea/sequencer/txselection/LineaTransactionSelectorPlugin.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,16 +38,10 @@
@Slf4j
@AutoService(BesuPlugin.class)
public class LineaTransactionSelectorPlugin extends AbstractLineaRequiredPlugin {
public static final String NAME = "linea";
private TransactionSelectionService transactionSelectionService;
private Optional<JsonRpcManager> rejectedTxJsonRpcManager = Optional.empty();
private BesuConfiguration besuConfiguration;

@Override
public Optional<String> getName() {
return Optional.of(NAME);
}

@Override
public void doRegister(final BesuContext context) {
transactionSelectionService =
Expand Down
Loading