Add AllDenomMetadata BankQuery #1426
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 31, 2023
Closed
chipshort
force-pushed
the
denom-metadata-query
branch
from
904f185
to
9eb407f
Compare
alpe
reviewed
Jun 12, 2023
alpe
reviewed
Jun 23, 2023
There was a problem hiding this comment.
Thanks a lot for adding the requested test cases! I appreciate the work a lot and added some detailed feedback on the test code in return. The tests are helping and there is no hard requirement to change them. Just sharing a bit of knowledge from working a lot in Go projects.
|
Thanks again for the updates. Good work! |
|
Linking #1296 to unblock this |
…omMetadata BankQuery
chipshort
force-pushed
the
denom-metadata-query
branch
from
7d035ca
to
6ffe54a
Compare
Closed
mergify bot
pushed a commit
that referenced
this pull request
Jul 18, 2023
* x/wasm: add AllDenomMetadata BankQuery * x/wasm: fix AllDenomMetadata BankQuery to have pagination and add DenomMetadata BankQuery * Use simplified pagination * Fix request conversion * Add unknown denom test cases * Add test for pagination conversion * Fix nits * Use wasmvm 1.3.0-rc.0 * Fix test --------- Co-authored-by: Nikhil Suri <[email protected]> (cherry picked from commit d2e9ace) # Conflicts: # x/wasm/keeper/query_plugins.go
alpe
added a commit
that referenced
this pull request
Jul 19, 2023
* Add AllDenomMetadata BankQuery (#1426) * x/wasm: add AllDenomMetadata BankQuery * x/wasm: fix AllDenomMetadata BankQuery to have pagination and add DenomMetadata BankQuery * Use simplified pagination * Fix request conversion * Add unknown denom test cases * Add test for pagination conversion * Fix nits * Use wasmvm 1.3.0-rc.0 * Fix test --------- Co-authored-by: Nikhil Suri <[email protected]> (cherry picked from commit d2e9ace) # Conflicts: # x/wasm/keeper/query_plugins.go * Resolve conflicts --------- Co-authored-by: Christoph Otter <[email protected]> Co-authored-by: Alex Peters <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See also CosmWasm/wasmvm#430 and CosmWasm/cosmwasm#1703