Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add AllDenomMetadata BankQuery #430

Merged
merged 8 commits into from
Jul 5, 2023
Merged

Add AllDenomMetadata BankQuery #430

merged 8 commits into from
Jul 5, 2023

Conversation

chipshort
Copy link
Collaborator

@chipshort chipshort commented May 31, 2023 •
edited
Loading

based on #409
I removed the fields we don't need from PageRequest and added NextKey to the response for the paginated query

See also CosmWasm/wasmd#1426 and CosmWasm/cosmwasm#1703

This was referenced May 31, 2023
Closed
Merged
Merged
@nik-suri nik-suri mentioned this pull request Jun 7, 2023
Closed
alpe
alpe reviewed Jun 12, 2023
View reviewed changes
Copy link
Contributor

@alpe alpe left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work. I have added some nits about Godoc conventions. It would be good to have this consistent, so that we can use the tools.

types/queries.go Outdated Show resolved Hide resolved
types/queries.go Outdated Show resolved Hide resolved
types/types.go Outdated Show resolved Hide resolved
types/types.go Outdated Show resolved Hide resolved
@webmaster128 webmaster128 added this to the 1.3.0 milestone Jun 22, 2023
@chipshort chipshort requested a review from alpe July 3, 2023 09:42
webmaster128
webmaster128 reviewed Jul 4, 2023
View reviewed changes
types/queries.go Outdated Show resolved Hide resolved
types/types.go Outdated Show resolved Hide resolved
@webmaster128 webmaster128 merged commit 94c5bf2 into main Jul 5, 2023
@webmaster128 webmaster128 deleted the chipshort/denom-metadata-query branch July 5, 2023 10:10
@chipshort chipshort mentioned this pull request Jul 5, 2023
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@webmaster128 webmaster128 webmaster128 approved these changes

@alpe alpe Awaiting requested review from alpe

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.3.0
Development

Successfully merging this pull request may close these issues.
4 participants
@chipshort @alpe @webmaster128 @nik-suri