-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EP-2378 Require amount to be submitted for recurring self-service #987
base: ep-upgrade
Are you sure you want to change the base?
EP-2378 Require amount to be submitted for recurring self-service #987
Conversation
@wrandall22 Definitely need some feedback on this. I'm flying by the seat of my pants, haha. |
This may not be something we want. I'll need to look at the code again, but it may be treating empty values as unchanged currently, which this would hinder. |
Yes, I believe you're right.
From my understanding, this wouldn't have an impact on that? This new method only gets called in the context of checking whether the form submit button should be disabled or not. Theoretically this code shouldn't affect the actual processing of the data, later? That was my intent, at least. |
There seems to be validation in place already that may not be firing when setting up a new gift here. |
Yep, I looked at that. That is working correctly, however it does nothing to actually disable the submit button. So even though an error message displays and there are checks in place to ensure invalid strings are not entered, you can still just hit the "submit" button anyway with a blank or "error-ing" input. That is what I am trying to remedy. |
Tested in staging-- This change works perfectly for UPDATING gifts. Does not seem to work for creating new ones though. I guess I was mistaken that both actions used the same part of the code. I’ll figure out a fix. |
…for someone who actually knows this stuff
Lee said I should probably leave this for Bill's team to take over at this point, since this is not in my scope of work. I am abandoning this branch for someone else to take over. |
EP-2378 8.1 UI Self Service allows submit of new recurring gifts with no amount
I have no idea if this would work. I've only just begun looking at the front end, so this is all new to me. I'm trying to disable the submit button if the amount is invalid, same as it currently gets disabled if a payment method is invalid.