fix transition input/output not showing up, add fixme note #5947
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r createPartsList
mwdchang
requested review from
YohannParis,
jryu01,
Tom-Szendrey,
shawnyama,
blanchco,
asylves1 and
mloppie
as code owners
Tom-Szendrey
approved these changes
Jan 2, 2025
blanchco
approved these changes
Jan 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #5882
Summary
The predicate
input && outputis incorrect because the sides can be imbalanced. A transition does not necessarily need to have an input (a production) or an output (a degradation). Added a fixme note to address the disjunctive typings.Before, note the "units" are showing for some transitions, which doesn't make sense as units are on the states.
After:
Testing
View the transition table for the model here, that has a a mix up production and degradation transitions:
non_mass_conserved.json