Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix transition input/output not showing up, add fixme note #5947

Merged
merged 2 commits into from
Jan 2, 2025
Merged

fix transition input/output not showing up, add fixme note #5947

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
df50f32
fix transition input/output not showing up, add fixme note to refacto…
mwdchang Jan 2, 2025
4dc447b
nelson recommendation
mwdchang Jan 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/client/hmi-client/src/components/model/model-parts/tera-model-part-entry.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
/>
</span>
<span class="unit" :class="{ time: isTimePart }">
<template v-if="input && output">
<template v-if="input || output">
<span><label>Input:</label> {{ input }}</span>
<span><label>Output:</label> {{ output }}</span>
</template>
Expand Down
2 changes: 2 additions & 0 deletions packages/client/hmi-client/src/model-representation/service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -358,6 +358,8 @@ export enum PartType {
TRANSITION = 'TRANSITION'
}

// FIXME: should refactor so typing is explicit and clear
// Note "model" is both an AMR model, or it can be a list of transition templates
export function createPartsList(parts, model, partType) {
return Array.from(parts.keys()).map((id) => {
const childTargets = parts.get(id) ?? [];
Expand Down