Merge pull request #425 from DFE-Digital/GET-875-duplicate-aria-labels

Accessibility fix: IDs used in ARIA and labels must be unique
DFE-Digital · Jan 15, 2020 · 9891db1 · 9891db1
2 parents 71981db + 7a7f959
commit 9891db1
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/app/views/job_profiles/_job_profile.html.erb b/app/views/job_profiles/_job_profile.html.erb
@@ -11,10 +11,10 @@
   <p class="govuk-body govuk-!-margin-bottom-1">Recent job growth: <span class="strong"><%= job_profile.growth_type %></span></p>
   <% if job_profile.growth.present? %>
     <details class="govuk-details" data-module="govuk-details">
-      <summary class="govuk-details__summary" aria-controls="recent-growth-details" aria-expanded="true" role="button">
+      <summary class="govuk-details__summary" aria-controls="recent-growth-details-<%= job_profile.slug %>" aria-expanded="true" role="button">
         <span class="govuk-details__summary-text">What does <%= job_profile.growth_type.downcase %> mean?</span>
       </summary>
-      <div class="govuk-details__text govuk-body-m" aria-hidden="false" id="recent-growth-details">
+      <div class="govuk-details__text govuk-body-m" aria-hidden="false" id="recent-growth-details-<%= job_profile.slug %>">
         <%= job_profile.growth_explanation %>
       </div>
     </details>