Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT/#8] Week2 / 심화 과제 #11

Merged
merged 8 commits into from
Oct 29, 2023

Conversation

kangyuri1114
Copy link
Member

@kangyuri1114 kangyuri1114 commented Oct 27, 2023

📌𝘐𝘴𝘴𝘶𝘦𝘴

📓 정리 노션

프래그먼트 정리 추가
2주차 정리노션

📎𝘞𝘰𝘳𝘬 𝘋𝘦𝘴𝘤𝘳𝘪𝘱𝘵𝘪𝘰𝘯

📷𝘚𝘤𝘳𝘦𝘦𝘯𝘴𝘩𝘰𝘵

_2023_10_27_23_20_56_933.mp4

💬𝘛𝘰 𝘙𝘦𝘷𝘪𝘦𝘸𝘦𝘳𝘴

사실 listAdapter 로 바꾸는 것도 시도했는데...! Sealed class인 경우에는 어떻게 할지...... 헷갈려서 우선 구현한 부분 먼저 올립니당 주로 디자인 변경만 있어요..!
listAdapter 는 조금 더 공부해보도록 할게욥..

@kangyuri1114 kangyuri1114 self-assigned this Oct 27, 2023
@kangyuri1114 kangyuri1114 changed the title Feat/#8 week2 advanced [FEAT/#8] Week2 / 심화/ 과제 Oct 27, 2023
@kangyuri1114 kangyuri1114 added the 🌳심화 심화 과제 label Oct 27, 2023
@kangyuri1114 kangyuri1114 changed the title [FEAT/#8] Week2 / 심화/ 과제 [FEAT/#8] Week2 / 심화 과제 Oct 27, 2023
Copy link
Member

@Marchbreeze Marchbreeze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

조씁니다 ~~~~~

Comment on lines +62 to +66
fun updown_Listener(view: RecyclerView?) {
binding.bnvHome.setOnClickListener {
view?.smoothScrollToPosition(0)
}
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

함수 네이밍 주의해주세요 !! 카멜 케이스로 작성해야합니다

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

헉 수정하도록 하겠습니답

Comment on lines +18 to +21
val args = Bundle()
args.putString("userId", userId)
args.putString("userNickname", userNickname)
args.putString("userAge", userAge)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

스코프 함수 써주면 더 예쁠듯 ~~

Comment on lines +2 to +12
<selector xmlns:android="http://schemas.android.com/apk/res/android">

<item
android:state_checked="true"
android:color="@color/bnv_dark_purple" />

<item
android:state_checked="false"
android:color="@color/bnv_light_purple" />

</selector>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

오호 ~~~~~~~~ 좋아요

@kangyuri1114 kangyuri1114 merged commit 81e21c2 into #7-week2-essential Oct 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌳심화 심화 과제
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants