generated from DO-SOPT-ANDROID/do-sopt-android-repo-template
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEAT/#8] Week2 / 심화 과제 #11
Merged
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
2538239
[MOD/#8] 프래그먼트 newInstance() 함수 적용
kangyuri1114 57aeaa6
[MOD/#8] 프래그먼트 초기화 함수 생성
kangyuri1114 f05fd0b
[MOD/#8] 프래그먼트 초기화 함수 생성
kangyuri1114 e95612d
[RENAME/#8] 함수 이름 변경
kangyuri1114 75f01df
[FEAT/#8] 리사이클러뷰 최상단으로 이동을 시도..
kangyuri1114 419daad
[RENAME/#8] 모종의 이유로.. DummyFriendsData를 임포트 못해서.. 리네임해봤는데.... 잘 되는 건에…
kangyuri1114 8036cbb
[FIX/#8] NPE 발생 후 수정
kangyuri1114 39ac9a6
[UI/#8] BNV selector 활용해 터치되었을때, 아닐때 색변경
kangyuri1114 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -12,6 +12,17 @@ import org.sopt.dosopttemplate.di.UserSharedPreferences | |
import org.sopt.dosopttemplate.presentation.auth.LoginActivity | ||
|
||
class MypageFragment : Fragment() { | ||
companion object { | ||
fun newInstance(userId: String?, userNickname: String?, userAge: String?): MypageFragment { | ||
val fragment = MypageFragment() | ||
val args = Bundle() | ||
args.putString("userId", userId) | ||
args.putString("userNickname", userNickname) | ||
args.putString("userAge", userAge) | ||
Comment on lines
+18
to
+21
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 스코프 함수 써주면 더 예쁠듯 ~~ |
||
fragment.arguments = args | ||
return fragment | ||
} | ||
} | ||
|
||
private var _binding: FragmentMypageBinding? = null | ||
private val binding: FragmentMypageBinding | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,12 @@ | ||
<?xml version="1.0" encoding="utf-8"?> | ||
<selector xmlns:android="http://schemas.android.com/apk/res/android"> | ||
|
||
<item | ||
android:state_checked="true" | ||
android:color="@color/bnv_dark_purple" /> | ||
|
||
<item | ||
android:state_checked="false" | ||
android:color="@color/bnv_light_purple" /> | ||
|
||
</selector> | ||
Comment on lines
+2
to
+12
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 오호 ~~~~~~~~ 좋아요 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
함수 네이밍 주의해주세요 !! 카멜 케이스로 작성해야합니다
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
헉 수정하도록 하겠습니답