Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/syntax check #2659

Merged
merged 9 commits into from
Sep 19, 2024
Merged

Fix/syntax check #2659

merged 9 commits into from
Sep 19, 2024

Conversation

Kevinjil
Copy link
Contributor

Currently, only files in the .github/jobs directory are tested.

@vmcj vmcj marked this pull request as draft August 25, 2024 15:40
@Kevinjil Kevinjil requested a review from meisterT August 25, 2024 19:12
@Kevinjil Kevinjil marked this pull request as ready for review August 25, 2024 19:12
vmcj
vmcj reviewed Aug 25, 2024
View reviewed changes
.github/jobs/syntax-check Show resolved Hide resolved
judge/runguard_test/runguard_test.sh Show resolved Hide resolved
judge/version_check.sh Outdated Show resolved Hide resolved
sql/files/defaultdata/r/run Show resolved Hide resolved
sql/dj_setup_database.in Outdated Show resolved Hide resolved
eldering
eldering reviewed Aug 25, 2024
View reviewed changes
etc/gen_all_secrets Outdated Show resolved Hide resolved
gitlab/integration.sh Outdated Show resolved Hide resolved
judge/runguard_test/runguard_test.sh Show resolved Hide resolved
sql/dj_setup_database.in Show resolved Hide resolved
sql/dj_setup_database.in Show resolved Hide resolved
sql/dj_setup_database.in Show resolved Hide resolved
vmcj
vmcj reviewed Aug 25, 2024
View reviewed changes
judge/runguard_test/runguard_test.sh Show resolved Hide resolved
misc-tools/dj_run_chroot.in Show resolved Hide resolved
judge/runguard_test/runguard_test.sh Show resolved Hide resolved
.github/jobs/syntax-check Show resolved Hide resolved
@Kevinjil
Fix syntax-check directory
9ff3c5e 
Currently, only files in the `.github/jobs` directory are tested.
@Kevinjil
Use shell compatible exit code
e5c802b
@Kevinjil
Fix shellcheck errors
692ac6b
@Kevinjil
Fix syntax-check errors
ec379b7 
As the CI job was not correctly run for some time, a lot of small errors
were in the repository.
@Kevinjil
Make chmod only for script directory explicit
82bfbc9
@Kevinjil
Use printf for the prompt question
b89ff1f
@Kevinjil Kevinjil mentioned this pull request Sep 19, 2024
Open
@Kevinjil
Note we should revert shellcheck-disable later
4f8a876 
Suggested-by: Michael Vasseur <[email protected]>
Signed-off-by: Kevin Jilissen <[email protected]>
@Kevinjil
Use printf instead
58d999e 
Suggested-by: Jaap Eldering <[email protected]>
Signed-off-by: Kevin Jilissen <[email protected]>
@Kevinjil
Use quiet grep for detecting cgroup version
443ecda 
Suggested-by: Jaap Eldering <[email protected]>
Signed-off-by: Kevin Jilissen <[email protected]>
vmcj
vmcj approved these changes Sep 19, 2024
View reviewed changes
Copy link
Member

@vmcj vmcj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can live with this, let's merge and actually have a test again.

@vmcj vmcj added this pull request to the merge queue Sep 19, 2024
Merged via the queue into DOMjudge:main with commit 7a6ac2e Sep 19, 2024
26 checks passed
@Kevinjil Kevinjil deleted the fix/syntax-check branch September 19, 2024 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eldering eldering eldering left review comments

@nickygerritsen nickygerritsen nickygerritsen approved these changes

@vmcj vmcj vmcj approved these changes

@meisterT meisterT Awaiting requested review from meisterT

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Kevinjil @meisterT @nickygerritsen @eldering @vmcj