Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/syntax check #2659

Merged
merged 9 commits into from
Sep 19, 2024
Merged

Fix/syntax check #2659

merged 9 commits into from
Sep 19, 2024

Commits on Sep 19, 2024

  1. Fix syntax-check directory 

    Currently, only files in the `.github/jobs` directory are tested.
    @Kevinjil
    Kevinjil committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    9ff3c5e View commit details
    Browse the repository at this point in the history

  2. Use shell compatible exit code

    @Kevinjil
    Kevinjil committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    e5c802b View commit details
    Browse the repository at this point in the history

  3. Fix shellcheck errors

    @Kevinjil
    Kevinjil committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    692ac6b View commit details
    Browse the repository at this point in the history

  4. Fix syntax-check errors 

    As the CI job was not correctly run for some time, a lot of small errors
were in the repository.
    @Kevinjil
    Kevinjil committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    ec379b7 View commit details
    Browse the repository at this point in the history

  5. Make chmod only for script directory explicit

    @Kevinjil
    Kevinjil committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    82bfbc9 View commit details
    Browse the repository at this point in the history

  6. Use printf for the prompt question

    @Kevinjil
    Kevinjil committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    b89ff1f View commit details
    Browse the repository at this point in the history

  7. Note we should revert shellcheck-disable later 

    Suggested-by: Michael Vasseur <[email protected]>
Signed-off-by: Kevin Jilissen <[email protected]>
    @Kevinjil
    Kevinjil committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    4f8a876 View commit details
    Browse the repository at this point in the history

  8. Use printf instead 

    Suggested-by: Jaap Eldering <[email protected]>
Signed-off-by: Kevin Jilissen <[email protected]>
    @Kevinjil
    Kevinjil committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    58d999e View commit details
    Browse the repository at this point in the history

  9. Use quiet grep for detecting cgroup version 

    Suggested-by: Jaap Eldering <[email protected]>
Signed-off-by: Kevin Jilissen <[email protected]>
    @Kevinjil
    Kevinjil committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    443ecda View commit details
    Browse the repository at this point in the history