Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New microservices image with working RunServices #81

Closed
wants to merge 146 commits into from

Conversation

TiagoTAlves
Copy link
Collaborator

@TiagoTAlves TiagoTAlves commented Dec 13, 2023

This Pull Request creates a RunNumber, RunRegistryMeta and RunRegistryConfigs table which allows for the storage of run services data related to nanorc in daq-kube.
These changes will be used to create a unified microservices image which will find the run services postgresql pod which has a database already deployed and add the tables to the already created database. These tables are created using flask_sqlalchemy.
All mentions of Oracle have been replaced with PostgresSQL.

The structure of these is as follows (for both both runnumber-rest and runregistry-rest):

  • A rest.py - This calls upon the other python files and creates the applications
  • A datbase.py - This creates the tables as python classes using flask_sqlalchemy
  • A authentication.py - This creates a username and password to access the API's
  • An api.py - This creates the api queries for accessing and inserting data into the database using sqlalchemy directly
  • An entrypoint.sh - This creates and entrypoint for the respective runservice in the image
  • A deployment.yaml - This is a copy of the deployment.yaml file in daq-kube

This PR also requires the https://github.com/DUNE-DAQ/daq-kube/pull/35 to be approved too.

TODO: Need to create new microservices dependencies image as well as microservices image

@TiagoTAlves TiagoTAlves closed this Apr 9, 2024
@jcpunk
Copy link
Contributor

jcpunk commented Apr 9, 2024

Why did you close this out?

@TiagoTAlves
Copy link
Collaborator Author

I closed it because people were getting confused between both pull requests, once the other was merged I'd reopen the request. If you think this is the wrong approach we could open it again

@jcpunk
Copy link
Contributor

jcpunk commented Apr 9, 2024

This is the one with the actual python changes. If you're talking about the daq-kube pr, I'd close that one and re-open this instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants