-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New microservices image with working RunServices #81
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcpunk
force-pushed
the
riehecky/runnumber_reorg
branch
from
February 29, 2024 18:31
b152917
to
fa83032
Compare
jcpunk
force-pushed
the
riehecky/runnumber_reorg
branch
from
February 29, 2024 18:58
a726298
to
ded3fc2
Compare
…t..." This reverts commit ded3fc2.
…eted database and authentication from runnumber_rest and called the same python files from runregistry_rest
Making some changes on a different branch, just in case you're unhappy with them and want to do them in a different way
It should now be able to listen on both ports and evaluate queries within a sql transaction set for better atomic bits.
Why did you close this out? |
I closed it because people were getting confused between both pull requests, once the other was merged I'd reopen the request. If you think this is the wrong approach we could open it again |
This is the one with the actual python changes. If you're talking about the daq-kube pr, I'd close that one and re-open this instead. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull Request creates a RunNumber, RunRegistryMeta and RunRegistryConfigs table which allows for the storage of run services data related to nanorc in daq-kube.
These changes will be used to create a unified microservices image which will find the run services postgresql pod which has a database already deployed and add the tables to the already created database. These tables are created using flask_sqlalchemy.
All mentions of Oracle have been replaced with PostgresSQL.
The structure of these is as follows (for both both runnumber-rest and runregistry-rest):
This PR also requires the https://github.com/DUNE-DAQ/daq-kube/pull/35 to be approved too.
TODO: Need to create new microservices dependencies image as well as microservices image