Fix and Feature: standardize config behavior across tracing libs #2873
+387
−57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenchmarksBenchmark execution time: 2024-10-03 19:34:39 Comparing candidate commit 09b6d5d in PR branch Found 1 performance improvements and 1 performance regressions! Performance is the same for 56 metrics, 1 unstable metrics. scenario:BenchmarkInjectW3C-24
scenario:BenchmarkSetTagStringer-24
|
mtoffl01
force-pushed
the
mtoff/config-consistency
branch
from
9c829ae
to
48ea87b
Compare
…4xx codes, not 5xx
mtoffl01
force-pushed
the
mtoff/config-consistency
branch
from
2f959a7
to
4bd670f
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
mtoffl01
force-pushed
the
mtoff/config-consistency
branch
2 times, most recently
from
8912f64
to
72c22f6
Compare
mtoffl01
force-pushed
the
mtoff/config-consistency
branch
from
72c22f6
to
8d242b8
Compare
mtoffl01
force-pushed
the
mtoff/config-consistency
branch
3 times, most recently
from
0989e3d
to
c7e46fe
Compare
Small note: Only overwrite 0 -> 200 code if 0 was not specified in DD_TRACE_HTTP_SERVER_ERROR_STATUSES
mtoffl01
force-pushed
the
mtoff/config-consistency
branch
from
c7e46fe
to
ca9fedd
Compare
mtoffl01
force-pushed
the
mtoff/config-consistency
branch
2 times, most recently
from
57de51d
to
bb3adb9
Compare
github-actions
bot
added
the
apm:ecosystem
3 tasks
mtoffl01
changed the title
mtoffl01
force-pushed
the
mtoff/config-consistency
branch
from
bb3adb9
to
44a216a
Compare
mtoffl01
force-pushed
the
mtoff/config-consistency
branch
from
44a216a
to
767938c
Compare
eliottness
approved these changes
Oct 2, 2024
darccio
reviewed
Oct 2, 2024
contrib/net/http/roundtripper.go
Outdated
| // treat 5XX as errors | ||
| if res.StatusCode/100 == 5 { | ||
| // Client spans consider 4xx as errors | ||
| if res.StatusCode/100 == 4 { |
There was a problem hiding this comment.
Isn't this a breaking behavioural change? Should we introduce an environment variable to allow keeping the old behaviour or would it be enough to set DD_TRACE_HTTP_CLIENT_ERROR_STATUSES to the right values?
There was a problem hiding this comment.
@darccio , yes it is a breaking change, although in my opinion it's a "fix" as the http client spans should always have had 4xx as errors, not 5xx.
We can discuss further.
contrib/net/http/http_test.go
Outdated
| @@ -516,11 +516,11 @@ func router(muxOpts ...Option) http.Handler { | |||
| return mux | |||
| } | |||
|
|
|||
| func handler200(w http.ResponseWriter, _ *http.Request) { | |||
| func handler200(w http.ResponseWriter, r *http.Request) { | |||
There was a problem hiding this comment.
In the body of the function this variable isn't used. Is it needed due to another reason?
darccio
approved these changes
Oct 2, 2024
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change makes Go "consistent" with other tracing libraries for a given list of configurations; for some configs, the behavior has been changed; for others, support is introduced for the first time. RFC is linked under "Motivation." This is not an exhaustive list.
Also, adds telemetry report for
trace_rate_limit.Each change is in its own commit for ease of review, except for the very last commit, which just does some cleanup.
Telemetry changes: Commit
Configurations made consistent:
(This means they already existed in dd-trace-go, but their behavior was modified):
DD_TRACE_CLIENT_IP_ENABLEDis set to true, we report ahttp.client_iptag whose value is populated from a list of "default headers." This PR fixes this list to includecf-connecting-ipv6instead ofcf-connecting-ip6(The former is correct according to the spec). CommitConfigurations introduced:
DD_TRACE_HTTP_CLIENT_TAG_QUERY_STRING: Boolean that determines whether or not to include query params in http.url tag for http client spans. CommitDD_TRACE_HTTP_CLIENT_ERROR_STATUSES: Customize errors on http client spans. CommitDD_TRACE_HTTP_CLIENT_ERROR_STATUSES: Customize errors on http server spans. CommitNote: support for
DD_TRACE_LOG_DIRECTORYis also added as part of this effort, but for ease of review, the changes are in a separate PR since the implementation was slightly more complex.Motivation
RFC
Ensure behavior is consistent across tracing libs for a given list of configurations.
Reviewer's Checklist
Unsure? Have a question? Request a review!