-
Notifications
You must be signed in to change notification settings - Fork 412
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(fastapi): do not use deprecated import path #10652
Conversation
Does this really need a changelog or can someone add a label @mabdinur @erikayasuda @quinna-h ? |
What version were you using when this happened? I think we should add a release note and backport to that version. |
2.12.2 shows this at least. |
Current code generates warning: ddtrace.DDTraceDeprecationWarning: ddtrace.contrib.asgi.middleware.__path__ is deprecated
c80e574
to
e052f7c
Compare
Added releasenote. |
@P403n1x87 what's missing for this to get merged and released? |
1 similar comment
@P403n1x87 what's missing for this to get merged and released? |
@jd it seems there is a failing debugger test, I am guessing unrelated to your change, once we get that sorted we can get this merged. |
@jd CI had to be triggered manually by a member of the team. Once it's finished, the PR should merge 🤞 |
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.12 2.12
# Navigate to the new working tree
cd .worktrees/backport-2.12
# Create a new branch
git switch --create backport-10652-to-2.12
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 adb07ac09d04617d23085e9e0feaaa96d378cc9a
# Push it to GitHub
git push --set-upstream origin backport-10652-to-2.12
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.12 Then, create a pull request where the |
Current code generates warning: ddtrace.DDTraceDeprecationWarning: ddtrace.contrib.asgi.middleware.__path__ is deprecated ## Checklist - [X] PR author has checked that all the criteria below are met - The PR description includes an overview of the change - The PR description articulates the motivation for the change - The change includes tests OR the PR description describes a testing strategy - The PR description notes risks associated with the change, if any - Newly-added code is easy to change - The change follows the [library release note guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html) - The change includes or references documentation updates if necessary - Backport labels are set (if [applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)) ## Reviewer Checklist - [x] Reviewer has checked that all the criteria below are met - Title is accurate - All changes are related to the pull request's stated goal - Avoids breaking [API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces) changes - Testing strategy adequately addresses listed risks - Newly-added code is easy to change - Release note makes sense to a user of the library - If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment - Backport labels are set in a manner that is consistent with the [release branch maintenance policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting) Co-authored-by: erikayasuda <[email protected]> (cherry picked from commit adb07ac)
Current code generates warning: ddtrace.DDTraceDeprecationWarning: ddtrace.contrib.asgi.middleware.__path__ is deprecated ## Checklist - [X] PR author has checked that all the criteria below are met - The PR description includes an overview of the change - The PR description articulates the motivation for the change - The change includes tests OR the PR description describes a testing strategy - The PR description notes risks associated with the change, if any - Newly-added code is easy to change - The change follows the [library release note guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html) - The change includes or references documentation updates if necessary - Backport labels are set (if [applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)) ## Reviewer Checklist - [x] Reviewer has checked that all the criteria below are met - Title is accurate - All changes are related to the pull request's stated goal - Avoids breaking [API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces) changes - Testing strategy adequately addresses listed risks - Newly-added code is easy to change - Release note makes sense to a user of the library - If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment - Backport labels are set in a manner that is consistent with the [release branch maintenance policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting) Co-authored-by: erikayasuda <[email protected]>
Current code generates warning:
ddtrace.DDTraceDeprecationWarning: ddtrace.contrib.asgi.middleware.path is deprecated
Checklist
Reviewer Checklist