Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(fastapi): do not use deprecated import path #10652

Merged
merged 2 commits into from
Sep 24, 2024

Conversation

jd
Copy link
Contributor

@jd jd commented Sep 13, 2024

Current code generates warning:
ddtrace.DDTraceDeprecationWarning: ddtrace.contrib.asgi.middleware.path is deprecated

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

@jd jd requested review from a team as code owners September 13, 2024 08:22
@jd
Copy link
Contributor Author

jd commented Sep 16, 2024

Does this really need a changelog or can someone add a label @mabdinur @erikayasuda @quinna-h ?

@P403n1x87
Copy link
Contributor

Does this really need a changelog or can someone add a label @mabdinur @erikayasuda @quinna-h ?

What version were you using when this happened? I think we should add a release note and backport to that version.

@erikayasuda erikayasuda added changelog/no-changelog A changelog entry is not required for this PR. and removed changelog/no-changelog A changelog entry is not required for this PR. labels Sep 16, 2024
@jd
Copy link
Contributor Author

jd commented Sep 18, 2024

Does this really need a changelog or can someone add a label @mabdinur @erikayasuda @quinna-h ?

What version were you using when this happened? I think we should add a release note and backport to that version.

2.12.2 shows this at least.

Current code generates warning:
  ddtrace.DDTraceDeprecationWarning: ddtrace.contrib.asgi.middleware.__path__ is deprecated
@jd jd requested a review from a team as a code owner September 18, 2024 07:11
@jd
Copy link
Contributor Author

jd commented Sep 18, 2024

Added releasenote.
(I know the guidelines talks about backport but contributor have no way to add labels)

@jd
Copy link
Contributor Author

jd commented Sep 24, 2024

@P403n1x87 what's missing for this to get merged and released?

1 similar comment
@jd
Copy link
Contributor Author

jd commented Sep 24, 2024

@P403n1x87 what's missing for this to get merged and released?

@brettlangdon
Copy link
Member

@jd it seems there is a failing debugger test, I am guessing unrelated to your change, once we get that sorted we can get this merged.

@brettlangdon brettlangdon enabled auto-merge (squash) September 24, 2024 13:09
@P403n1x87
Copy link
Contributor

@P403n1x87 what's missing for this to get merged and released?

@jd CI had to be triggered manually by a member of the team. Once it's finished, the PR should merge 🤞

@brettlangdon brettlangdon merged commit adb07ac into DataDog:main Sep 24, 2024
570 of 571 checks passed
Copy link
Contributor

The backport to 2.12 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.12 2.12
# Navigate to the new working tree
cd .worktrees/backport-2.12
# Create a new branch
git switch --create backport-10652-to-2.12
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 adb07ac09d04617d23085e9e0feaaa96d378cc9a
# Push it to GitHub
git push --set-upstream origin backport-10652-to-2.12
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.12

Then, create a pull request where the base branch is 2.12 and the compare/head branch is backport-10652-to-2.12.

github-actions bot pushed a commit that referenced this pull request Sep 24, 2024
Current code generates warning:
ddtrace.DDTraceDeprecationWarning:
ddtrace.contrib.asgi.middleware.__path__ is deprecated

## Checklist
- [X] PR author has checked that all the criteria below are met
- The PR description includes an overview of the change
- The PR description articulates the motivation for the change
- The change includes tests OR the PR description describes a testing
strategy
- The PR description notes risks associated with the change, if any
- Newly-added code is easy to change
- The change follows the [library release note
guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html)
- The change includes or references documentation updates if necessary
- Backport labels are set (if
[applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting))

## Reviewer Checklist
- [x] Reviewer has checked that all the criteria below are met
- Title is accurate
- All changes are related to the pull request's stated goal
- Avoids breaking
[API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces)
changes
- Testing strategy adequately addresses listed risks
- Newly-added code is easy to change
- Release note makes sense to a user of the library
- If necessary, author has acknowledged and discussed the performance
implications of this PR as reported in the benchmarks PR comment
- Backport labels are set in a manner that is consistent with the
[release branch maintenance
policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)

Co-authored-by: erikayasuda <[email protected]>
(cherry picked from commit adb07ac)
mabdinur pushed a commit that referenced this pull request Sep 25, 2024
Current code generates warning:
ddtrace.DDTraceDeprecationWarning:
ddtrace.contrib.asgi.middleware.__path__ is deprecated

## Checklist
- [X] PR author has checked that all the criteria below are met
- The PR description includes an overview of the change
- The PR description articulates the motivation for the change
- The change includes tests OR the PR description describes a testing
strategy
- The PR description notes risks associated with the change, if any
- Newly-added code is easy to change
- The change follows the [library release note
guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html)
- The change includes or references documentation updates if necessary
- Backport labels are set (if
[applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting))

## Reviewer Checklist
- [x] Reviewer has checked that all the criteria below are met 
- Title is accurate
- All changes are related to the pull request's stated goal
- Avoids breaking
[API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces)
changes
- Testing strategy adequately addresses listed risks
- Newly-added code is easy to change
- Release note makes sense to a user of the library
- If necessary, author has acknowledged and discussed the performance
implications of this PR as reported in the benchmarks PR comment
- Backport labels are set in a manner that is consistent with the
[release branch maintenance
policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)

Co-authored-by: erikayasuda <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants