Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci(opentelemetry): pin opentelemetry-api version to unblock tests #9932

Merged
merged 3 commits into from
Jul 25, 2024
Merged

ci(opentelemetry): pin opentelemetry-api version to unblock tests #9932

merged 3 commits into from
Jul 25, 2024

Conversation

mabdinur
Copy link
Contributor

@mabdinur mabdinur commented Jul 25, 2024 •
edited by emmettbutler
Loading

Resolves the following failures: https://app.circleci.com/pipelines/github/DataDog/dd-trace-py/66676/workflows/fa3470d[…]2a-d3447f3f431a/jobs/4095885/parallel-runs/2?filterBy=FAILED in ci.

The opentelemetry-api broke compatibility with ddtrace in v1.25.0 and then introduced another breaking change in 1.26.0. This PR ensures the telemetry test suite uses a stable version of the opentelemetry-api.

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

@mabdinur mabdinur changed the title ci: pin opentelemetry-api in telemeetry tests ci: pin opentelemetry-api in telemetry tests Jul 25, 2024
@github-actions GitHub Actions
Copy link
Contributor

CODEOWNERS have been resolved as:

riotfile.py                                                             @DataDog/apm-python
.riot/requirements/12974a3.txt                                          @DataDog/apm-python
.riot/requirements/1677649.txt                                          @DataDog/apm-python
.riot/requirements/17c4377.txt                                          @DataDog/apm-python
.riot/requirements/18589ec.txt                                          @DataDog/apm-python
.riot/requirements/1a14242.txt                                          @DataDog/apm-python
.riot/requirements/5c0475c.txt                                          @DataDog/apm-python

@mabdinur mabdinur marked this pull request as ready for review July 25, 2024 13:57
@mabdinur mabdinur requested a review from a team as a code owner July 25, 2024 13:57
@mabdinur mabdinur requested a review from duncanista July 25, 2024 13:57
@datadog-dd-trace-py-rkomorn
Copy link

datadog-dd-trace-py-rkomorn bot commented Jul 25, 2024 •
edited
Loading

Datadog Report

Branch report: munir/pin-otel-version-used-in-telemetry-tests
Commit report: 3e6935e
Test service: dd-trace-py

✅ 0 Failed, 117632 Passed, 60649 Skipped, 3h 53m 46.46s Total duration (25m 54.59s time saved)

P403n1x87
P403n1x87 approved these changes Jul 25, 2024
View reviewed changes
Copy link
Contributor

@P403n1x87 P403n1x87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have the latest running in some nightly jobs? That way we can also keep a signal that there is something to fix.

@mabdinur mabdinur changed the title ci: pin opentelemetry-api in telemetry tests ci(opentelemetry): pin opentelemetry-api version to unblock tests Jul 25, 2024
@pr-commenter
Copy link

pr-commenter bot commented Jul 25, 2024 •
edited
Loading

Benchmarks

Benchmark execution time: 2024-07-25 14:30:34

Comparing candidate commit bb9928a in PR branch munir/pin-otel-version-used-in-telemetry-tests with baseline commit 3e1a49a in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 214 metrics, 2 unstable metrics.

@emmettbutler emmettbutler added the changelog/no-changelog A changelog entry is not required for this PR. label Jul 25, 2024
@emmettbutler emmettbutler self-requested a review July 25, 2024 14:21
@emmettbutler emmettbutler enabled auto-merge (squash) July 25, 2024 14:21
@emmettbutler emmettbutler merged commit 27cd94c into main Jul 25, 2024
206 checks passed
@emmettbutler emmettbutler deleted the munir/pin-otel-version-used-in-telemetry-tests branch July 25, 2024 14:46
github-actions bot pushed a commit that referenced this pull request Jul 25, 2024
@mabdinur @github-actions
ci(opentelemetry): pin opentelemetry-api version to unblock tests (#9932
48b4e2a 
)

Resolves the following failures:
[https://app.circleci.com/pipelines/github/DataDog/dd-trace-py/66676/workflows/fa3470d[…]2a-d3447f3f431a/jobs/4095885/parallel-runs/2?filterBy=FAILED](https://app.circleci.com/pipelines/github/DataDog/dd-trace-py/66676/workflows/fa3470d1-e065-43a1-9a2a-d3447f3f431a/jobs/4095885/parallel-runs/2?filterBy=FAILED)
in ci.

The `opentelemetry-api` broke compatibility with ddtrace in v1.25.0 and
then introduced another breaking change in 1.26.0. This PR ensures the
telemetry test suite uses a stable version of the `opentelemetry-api`.

## Checklist
- [x] PR author has checked that all the criteria below are met
- The PR description includes an overview of the change
- The PR description articulates the motivation for the change
- The change includes tests OR the PR description describes a testing
strategy
- The PR description notes risks associated with the change, if any
- Newly-added code is easy to change
- The change follows the [library release note
guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html)
- The change includes or references documentation updates if necessary
- Backport labels are set (if
[applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting))

## Reviewer Checklist
- [x] Reviewer has checked that all the criteria below are met
- Title is accurate
- All changes are related to the pull request's stated goal
- Avoids breaking
[API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces)
changes
- Testing strategy adequately addresses listed risks
- Newly-added code is easy to change
- Release note makes sense to a user of the library
- If necessary, author has acknowledged and discussed the performance
implications of this PR as reported in the benchmarks PR comment
- Backport labels are set in a manner that is consistent with the
[release branch maintenance
policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)

(cherry picked from commit 27cd94c)
@github-actions github-actions bot mentioned this pull request Jul 25, 2024
Merged
2 tasks
github-actions bot pushed a commit that referenced this pull request Jul 25, 2024
@mabdinur @github-actions
ci(opentelemetry): pin opentelemetry-api version to unblock tests (#9932
1e8850b 
)

Resolves the following failures:
[https://app.circleci.com/pipelines/github/DataDog/dd-trace-py/66676/workflows/fa3470d[…]2a-d3447f3f431a/jobs/4095885/parallel-runs/2?filterBy=FAILED](https://app.circleci.com/pipelines/github/DataDog/dd-trace-py/66676/workflows/fa3470d1-e065-43a1-9a2a-d3447f3f431a/jobs/4095885/parallel-runs/2?filterBy=FAILED)
in ci.

The `opentelemetry-api` broke compatibility with ddtrace in v1.25.0 and
then introduced another breaking change in 1.26.0. This PR ensures the
telemetry test suite uses a stable version of the `opentelemetry-api`.

## Checklist
- [x] PR author has checked that all the criteria below are met
- The PR description includes an overview of the change
- The PR description articulates the motivation for the change
- The change includes tests OR the PR description describes a testing
strategy
- The PR description notes risks associated with the change, if any
- Newly-added code is easy to change
- The change follows the [library release note
guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html)
- The change includes or references documentation updates if necessary
- Backport labels are set (if
[applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting))

## Reviewer Checklist
- [x] Reviewer has checked that all the criteria below are met
- Title is accurate
- All changes are related to the pull request's stated goal
- Avoids breaking
[API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces)
changes
- Testing strategy adequately addresses listed risks
- Newly-added code is easy to change
- Release note makes sense to a user of the library
- If necessary, author has acknowledged and discussed the performance
implications of this PR as reported in the benchmarks PR comment
- Backport labels are set in a manner that is consistent with the
[release branch maintenance
policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)

(cherry picked from commit 27cd94c)
@github-actions github-actions bot mentioned this pull request Jul 25, 2024
Merged
2 tasks
github-actions bot pushed a commit that referenced this pull request Jul 25, 2024
@mabdinur @github-actions
ci(opentelemetry): pin opentelemetry-api version to unblock tests (#9932
a795635 
)

Resolves the following failures:
[https://app.circleci.com/pipelines/github/DataDog/dd-trace-py/66676/workflows/fa3470d[…]2a-d3447f3f431a/jobs/4095885/parallel-runs/2?filterBy=FAILED](https://app.circleci.com/pipelines/github/DataDog/dd-trace-py/66676/workflows/fa3470d1-e065-43a1-9a2a-d3447f3f431a/jobs/4095885/parallel-runs/2?filterBy=FAILED)
in ci.

The `opentelemetry-api` broke compatibility with ddtrace in v1.25.0 and
then introduced another breaking change in 1.26.0. This PR ensures the
telemetry test suite uses a stable version of the `opentelemetry-api`.

## Checklist
- [x] PR author has checked that all the criteria below are met
- The PR description includes an overview of the change
- The PR description articulates the motivation for the change
- The change includes tests OR the PR description describes a testing
strategy
- The PR description notes risks associated with the change, if any
- Newly-added code is easy to change
- The change follows the [library release note
guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html)
- The change includes or references documentation updates if necessary
- Backport labels are set (if
[applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting))

## Reviewer Checklist
- [x] Reviewer has checked that all the criteria below are met
- Title is accurate
- All changes are related to the pull request's stated goal
- Avoids breaking
[API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces)
changes
- Testing strategy adequately addresses listed risks
- Newly-added code is easy to change
- Release note makes sense to a user of the library
- If necessary, author has acknowledged and discussed the performance
implications of this PR as reported in the benchmarks PR comment
- Backport labels are set in a manner that is consistent with the
[release branch maintenance
policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)

(cherry picked from commit 27cd94c)
@github-actions github-actions bot mentioned this pull request Jul 25, 2024
Merged
2 tasks
emmettbutler pushed a commit that referenced this pull request Jul 25, 2024
@github-actions @mabdinur
ci(opentelemetry): pin opentelemetry-api version to unblock tests [ba…
7e39ec5 
…ckport 2.10] (#9938)

Backport 27cd94c from #9932 to 2.10.

Resolves the following failures:
[https://app.circleci.com/pipelines/github/DataDog/dd-trace-py/66676/workflows/fa3470d[…]2a-d3447f3f431a/jobs/4095885/parallel-runs/2?filterBy=FAILED](https://app.circleci.com/pipelines/github/DataDog/dd-trace-py/66676/workflows/fa3470d1-e065-43a1-9a2a-d3447f3f431a/jobs/4095885/parallel-runs/2?filterBy=FAILED)
in ci.

The `opentelemetry-api` broke compatibility with ddtrace in v1.25.0 and
then introduced another breaking change in 1.26.0. This PR ensures the
telemetry test suite uses a stable version of the `opentelemetry-api`.

## Checklist
- [x] PR author has checked that all the criteria below are met
- The PR description includes an overview of the change
- The PR description articulates the motivation for the change
- The change includes tests OR the PR description describes a testing
strategy
- The PR description notes risks associated with the change, if any
- Newly-added code is easy to change
- The change follows the [library release note
guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html)
- The change includes or references documentation updates if necessary
- Backport labels are set (if
[applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting))

## Reviewer Checklist
- [x] Reviewer has checked that all the criteria below are met 
- Title is accurate
- All changes are related to the pull request's stated goal
- Avoids breaking
[API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces)
changes
- Testing strategy adequately addresses listed risks
- Newly-added code is easy to change
- Release note makes sense to a user of the library
- If necessary, author has acknowledged and discussed the performance
implications of this PR as reported in the benchmarks PR comment
- Backport labels are set in a manner that is consistent with the
[release branch maintenance
policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)

Co-authored-by: Munir Abdinur <[email protected]>
mabdinur added a commit that referenced this pull request Jul 25, 2024
@github-actions @mabdinur
ci(opentelemetry): pin opentelemetry-api version to unblock tests [ba…
d92891f 
…ckport 2.9] (#9937)

Backport 27cd94c from #9932 to 2.9.

Resolves the following failures:
[https://app.circleci.com/pipelines/github/DataDog/dd-trace-py/66676/workflows/fa3470d[…]2a-d3447f3f431a/jobs/4095885/parallel-runs/2?filterBy=FAILED](https://app.circleci.com/pipelines/github/DataDog/dd-trace-py/66676/workflows/fa3470d1-e065-43a1-9a2a-d3447f3f431a/jobs/4095885/parallel-runs/2?filterBy=FAILED)
in ci.

The `opentelemetry-api` broke compatibility with ddtrace in v1.25.0 and
then introduced another breaking change in 1.26.0. This PR ensures the
telemetry test suite uses a stable version of the `opentelemetry-api`.

## Checklist
- [x] PR author has checked that all the criteria below are met
- The PR description includes an overview of the change
- The PR description articulates the motivation for the change
- The change includes tests OR the PR description describes a testing
strategy
- The PR description notes risks associated with the change, if any
- Newly-added code is easy to change
- The change follows the [library release note
guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html)
- The change includes or references documentation updates if necessary
- Backport labels are set (if
[applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting))

## Reviewer Checklist
- [x] Reviewer has checked that all the criteria below are met 
- Title is accurate
- All changes are related to the pull request's stated goal
- Avoids breaking
[API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces)
changes
- Testing strategy adequately addresses listed risks
- Newly-added code is easy to change
- Release note makes sense to a user of the library
- If necessary, author has acknowledged and discussed the performance
implications of this PR as reported in the benchmarks PR comment
- Backport labels are set in a manner that is consistent with the
[release branch maintenance
policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)

Co-authored-by: Munir Abdinur <[email protected]>
gnufede pushed a commit that referenced this pull request Jul 26, 2024
@mabdinur @gnufede
ci(opentelemetry): pin opentelemetry-api version to unblock tests (#9932
bbd2514 
)

Resolves the following failures:
[https://app.circleci.com/pipelines/github/DataDog/dd-trace-py/66676/workflows/fa3470d[…]2a-d3447f3f431a/jobs/4095885/parallel-runs/2?filterBy=FAILED](https://app.circleci.com/pipelines/github/DataDog/dd-trace-py/66676/workflows/fa3470d1-e065-43a1-9a2a-d3447f3f431a/jobs/4095885/parallel-runs/2?filterBy=FAILED)
in ci.

The `opentelemetry-api` broke compatibility with ddtrace in v1.25.0 and
then introduced another breaking change in 1.26.0. This PR ensures the
telemetry test suite uses a stable version of the `opentelemetry-api`.

## Checklist
- [x] PR author has checked that all the criteria below are met
- The PR description includes an overview of the change
- The PR description articulates the motivation for the change
- The change includes tests OR the PR description describes a testing
strategy
- The PR description notes risks associated with the change, if any
- Newly-added code is easy to change
- The change follows the [library release note
guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html)
- The change includes or references documentation updates if necessary
- Backport labels are set (if
[applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting))

## Reviewer Checklist
- [x] Reviewer has checked that all the criteria below are met 
- Title is accurate
- All changes are related to the pull request's stated goal
- Avoids breaking
[API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces)
changes
- Testing strategy adequately addresses listed risks
- Newly-added code is easy to change
- Release note makes sense to a user of the library
- If necessary, author has acknowledged and discussed the performance
implications of this PR as reported in the benchmarks PR comment
- Backport labels are set in a manner that is consistent with the
[release branch maintenance
policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)
mabdinur added a commit that referenced this pull request Aug 2, 2024
@github-actions @mabdinur
ci(opentelemetry): pin opentelemetry-api version to unblock tests [ba…
1c2e737 
…ckport 2.8] (#9936)

Backport 27cd94c from #9932 to 2.8.

Resolves the following failures:
[https://app.circleci.com/pipelines/github/DataDog/dd-trace-py/66676/workflows/fa3470d[…]2a-d3447f3f431a/jobs/4095885/parallel-runs/2?filterBy=FAILED](https://app.circleci.com/pipelines/github/DataDog/dd-trace-py/66676/workflows/fa3470d1-e065-43a1-9a2a-d3447f3f431a/jobs/4095885/parallel-runs/2?filterBy=FAILED)
in ci.

The `opentelemetry-api` broke compatibility with ddtrace in v1.25.0 and
then introduced another breaking change in 1.26.0. This PR ensures the
telemetry test suite uses a stable version of the `opentelemetry-api`.

## Checklist
- [x] PR author has checked that all the criteria below are met
- The PR description includes an overview of the change
- The PR description articulates the motivation for the change
- The change includes tests OR the PR description describes a testing
strategy
- The PR description notes risks associated with the change, if any
- Newly-added code is easy to change
- The change follows the [library release note
guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html)
- The change includes or references documentation updates if necessary
- Backport labels are set (if
[applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting))

## Reviewer Checklist
- [x] Reviewer has checked that all the criteria below are met 
- Title is accurate
- All changes are related to the pull request's stated goal
- Avoids breaking
[API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces)
changes
- Testing strategy adequately addresses listed risks
- Newly-added code is easy to change
- Release note makes sense to a user of the library
- If necessary, author has acknowledged and discussed the performance
implications of this PR as reported in the benchmarks PR comment
- Backport labels are set in a manner that is consistent with the
[release branch maintenance
policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)

Co-authored-by: Munir Abdinur <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emmettbutler emmettbutler emmettbutler approved these changes

@brettlangdon brettlangdon brettlangdon approved these changes

@P403n1x87 P403n1x87 P403n1x87 approved these changes

@duncanista duncanista Awaiting requested review from duncanista duncanista is a code owner automatically assigned from DataDog/apm-python

Assignees
No one assigned
Labels
backport 2.8 backport 2.9 backport 2.10 changelog/no-changelog A changelog entry is not required for this PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mabdinur @emmettbutler @brettlangdon @P403n1x87