fix(opentelemetry): support attribute argument in TracerProvider.get_tracer() (backport #9941 to 2.9) #9963
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves incompatibility introduced by:
open-telemetry/opentelemetry-python@d4e13bd.
In
opentelemetry-api==1.26.0
,ddtrace.opentelemetry.TracerProvider.get_tracer(...)
gets called with attributes argument(here). This optional argument is not currently supported in ddtrace and this raises a TypeError when ddtrace-opentelemetry support is enabled.
This PR resolves this incompatibility by providing two implementations for
ddtrace.opentelemetry.TracerProvider.get_tracer
, one for opentelemetry-api>=1.26 and one for opentelemetry<1.26.Checklist
Reviewer Checklist