Commits on Jul 26, 2024

1. fix(opentelemetry): support attribute argument in TracerProvider.get_… …

   …tracer() (#9941)
   
   Resolves incompatibility introduced by:
   open-telemetry/opentelemetry-python@d4e13bd.
   
   In `opentelemetry-api==1.26.0`,
   `ddtrace.opentelemetry.TracerProvider.get_tracer(...)` gets called with
   attributes argument
   ([here](https://github.com/open-telemetry/opentelemetry-python/blob/v1.26.0/opentelemetry-api/src/opentelemetry/trace/__init__.py#L519)).
   This optional argument is not currently supported in ddtrace and this
   raises a TypeError when ddtrace-opentelemetry support is enabled.
   
   This PR resolves this incompatibility by providing two implementations
   for `ddtrace.opentelemetry.TracerProvider.get_tracer`, one for
   opentelemetry-api>=1.26 and one for opentelemetry<1.26.
   
   - [x] PR author has checked that all the criteria below are met
   - The PR description includes an overview of the change
   - The PR description articulates the motivation for the change
   - The change includes tests OR the PR description describes a testing
   strategy
   - The PR description notes risks associated with the change, if any
   - Newly-added code is easy to change
   - The change follows the [library release note
   guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html)
   - The change includes or references documentation updates if necessary
   - Backport labels are set (if
   [applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting))
   
   - [x] Reviewer has checked that all the criteria below are met
   - Title is accurate
   - All changes are related to the pull request's stated goal
   - Avoids breaking
   [API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces)
   changes
   - Testing strategy adequately addresses listed risks
   - Newly-added code is easy to change
   - Release note makes sense to a user of the library
   - If necessary, author has acknowledged and discussed the performance
   implications of this PR as reported in the benchmarks PR comment
   - Backport labels are set in a manner that is consistent with the
   [release branch maintenance
   policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)

   

   mabdinur committed Jul 26, 2024
   Configuration menu

   • View commit details
   • Copy full SHA for b9b9801
   • Browse repository at this point

   Copy the full SHA

   b9b9801 View commit details

   Browse the repository at this point in the history