symbolication: allow symbol upload for Bazel-built Go binairies #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bazel built Go binairies have their GNU build ID stripped, and their Go build ID set to the string "redacted" See https://github.com/bazelbuild/rules_go/blob/199d8e4827f87d382a85febd0148c1b42fa949cc/go/private/actions/link.bzl#L174 In that case, we want to able to rely on the file hash, for this reason we: - modify the function to get go build ID to consider that "redacted" is equivalent to not having a build ID - still upload debug symbols even if they don't contain a GNU build id or a Go build ID (they'll always contain a file hash, that we will be using for symbolication in that case). The underlying goal is to allow remote symbolication with local symbol upload to work seamless for Go binaries built with Bazel
r1viollet
approved these changes
Sep 3, 2024
Yes we definitely should 💯 Though since the logic / package architecture might change a bit in the near future with:
I would vote for investing in tests once we have those two bits in place - I'd prefer if we can merge this sooner to unblock symbolication for bazel-built Go binairies. I've captured this in https://datadoghq.atlassian.net/browse/PROF-10475. Let me know if that works for you! |
nsavoire
approved these changes
Sep 4, 2024
|
That works! I was interested in adding some tests, though I did not know where to do so. Happy to resume this discussion in a sync. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://datadoghq.atlassian.net/browse/PROF-10434
Bazel built Go binairies have their GNU build ID stripped, and their Go build ID set to the string "redacted"
See https://github.com/bazelbuild/rules_go/blob/199d8e4827f87d382a85febd0148c1b42fa949cc/go/private/actions/link.bzl#L174
In that case, we want to able to rely on the file hash, for this reason we:
The underlying goal is to allow remote symbolication with local symbol upload to work seamless for Go binaries built with Bazel
@DataDog/profiling-full-host