Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

symbolication: allow symbol upload for Bazel-built Go binairies #57

Merged
merged 1 commit into from
Sep 4, 2024

Commits on Sep 3, 2024

  1. symbolication: allow symbol upload for Bazel-built Go binairies

    Bazel built Go binairies have their GNU build ID stripped, and
    their Go build ID set to the string "redacted"
    See https://github.com/bazelbuild/rules_go/blob/199d8e4827f87d382a85febd0148c1b42fa949cc/go/private/actions/link.bzl#L174
    
    In that case, we want to able to rely on the file hash, for this
    reason we:
    - modify the function to get go build ID to consider that "redacted"
    is equivalent to not having a build ID
    - still upload debug symbols even if they don't contain a GNU build
    id or a Go build ID (they'll always contain a file hash, that
    we will be using for symbolication in that case).
    
    The underlying goal is to allow remote symbolication with local
    symbol upload to work seamless for Go binaries built with Bazel
    Gandem committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    eeff222 View commit details
    Browse the repository at this point in the history