-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Migrate pallets from standalone chain that was updated to common branch 'polkadot-v0.9.17' progressively #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ltfschoen
changed the title
WIP Attempt 2 Progressively Migrate pallets from standalone chain that was updated to common branch 'polkadot-v0.9.17'
feat: Migrate pallets from standalone chain that was updated to common branch 'polkadot-v0.9.17' progressively
Mar 13, 2022
ltfschoen
added a commit
to DataHighway-DHX/open-polkadot-js-library
that referenced
this pull request
Mar 15, 2022
…r-215-step-by-step-accountindex feat: Update MultiAddress with AccountIndex
…m from 4.7mb to 4.3mb
…council collective, technical collective, elections phragmen, tips to reduce .compact.wasm from 4.3mb to 3.4mb. remove bounties and child bounties to reduce to 3.3mb
…r-215-step-by-step-minimize-runtime feat: Minimize runtime size to allow for runtime upgrades
ayushmishra2005
suggested changes
Mar 17, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please create github issue for pending tasks and link with this PR.
runtime/Cargo.toml
Outdated
'pallet-aura/std', | ||
'pallet-authorship/std', | ||
'pallet-balances/std', | ||
'pallet-bounties/std', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fix indentation everywhere in this file
ayushmishra2005
previously approved these changes
Mar 17, 2022
23 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rev = '...'
to using latest branch for parachainbranch = 'polkadot-v0.9.17'
spec_version
andimpl_version
pub type Address = MultiAddress<AccountId, ()>;
withpub type Address = MultiAddress<AccountId, AccountIndex>;
like on standalone chainimpl<LocalCall> frame_system:',
impl frame_system::offchain::SigningTypes,
impl frame_system::offchain::SendTransactionTypes`, into implementation https://substrate.stackexchange.com/questions/613/what-does-trait-checkablechaincontextruntime-do-i-need-it-as-a-trait-boundUpdate: I've created this PR to try and incorporate the change feat: Update MultiAddress with AccountIndex #19, since i believe these changes are necessary to make transfers, but it generates an error as shown in the description of the PR, and i've asked for help here https://substrate.stackexchange.com/a/725/83
Update: Closing this item as it doesn't appear to be necessary as other live parachain projects aren't using it. See comments here Refactoring work #20
The cause of this problem is because the EXISTENTIAL_DEPOSIT is currently 1000000000000000, (i.e. 100 * MILLICENTS), but some of the balances in the hardspoon accounts that we are trying to import from the standalone chain had less than the existential deposit.
Fixed in this PR DataHighway-DHX/open-polkadot-js-library#8, and copied the latest data/ that was generated into the genesis.json, and that fixed the issue.
The runtime upgrade check where I only changed the existential deposit value generated a .compact.wasm file that was 6MB in size, so it was necessary to reduce it to less than 3.1MB. I have reduced the runtime size to 3.05MB so can perform runtime upgrades in PR #24
*
* [X] - metadata - check that no errors in polkadot.js using custom_types.json
cargo build --release --features runtime-benchmarks
, as it gives the following erorr even though we're not evening using frame society, and even thoughsuccessful_origin
is already implemented in that branch here https://github.com/paritytech/substrate/blob/22d40c7/frame/society/src/lib.rs#L1278Similar to this issue paritytech/substrate#10548
I have asked in "Builders Program - Chains Track" what Basti meant was required when he said: "forward the enabling of the runtime-benchmarks feature"
https://docs.substrate.io/how-to-guides/v3/tools/try-runtime/
https://docs.substrate.io/v3/tools/try-runtime/
Unable to run `cargo build --release --features=try-runtime
I thought it may be necessary to upgrade to v0.9.18, but I tried that in this PR and that didn't work #22
I have reduced the runtime size so can perform runtime upgrades in PR feat: Minimize runtime size to allow for runtime upgrades #24
DRAFT RELEASE MESSAGE