-
Notifications
You must be signed in to change notification settings - Fork 248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Add semantic PR Linter #1136
Conversation
Signed-off-by: Dave Skender <[email protected]>
Signed-off-by: Dave Skender <[email protected]>
Why is it not triggered? |
Signed-off-by: Dave Skender <[email protected]>
Signed-off-by: Dave Skender <[email protected]>
Okay, it works, just not on this initial PR when using |
Hey there and thank you for opening this pull request! 👋🏼It looks like your proposed title needs to be adjusted.
Pull request title naming conventionOur PR title name taxonomy is
See the Conventional Commits specification for more information. |
Adding enforcement of semantic conventional commit standards for PR titles.
to do
update PR template with other standards, like BREAKING CHANGEconsider also Semantic Release convention toolingcopy to other reposinitial configuration
In our implementation:
types
andscopes
requirements were not altered, using default settings and values (scope is not required, not do we recommend using it).subject
was adjusted to required that it starts with a Capitalized letter, for examplefeat: Poodle doodle
would pass, butfeat: poodle doodle
would fail. This implicitly also meanssubject
cannot start with symbols or numbers.