Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pluggable loggers including FileLogger #52

Merged
merged 14 commits into from
May 11, 2024
Merged

Pluggable loggers including FileLogger #52

merged 14 commits into from
May 11, 2024

Conversation

nowsprinting
Copy link
Contributor

Changes

  • Change logger settings to pluggable
  • Refactor and add filtering LogType option into ConsoleLogger
  • Add CompositeLogger
  • Add FileLogger

Discussions

Can I change Autopilot.CreateDefaultLogger method accessor to private?

Contribution License Agreement

@nowsprinting nowsprinting requested a review from a team as a code owner May 5, 2024 13:09
@nowsprinting
Copy link
Contributor Author

nowsprinting commented May 5, 2024 •
edited
Loading

I found a bug...
Fixed.

@nowsprinting nowsprinting marked this pull request as draft May 5, 2024 23:51
@nowsprinting nowsprinting marked this pull request as ready for review May 6, 2024 03:47
Kuniwak
Kuniwak reviewed May 9, 2024
View reviewed changes
Runtime/Loggers/CompositeLogger.cs Outdated Show resolved Hide resolved
Runtime/Loggers/AbstractLogger.cs Outdated Show resolved Hide resolved
@nowsprinting
Copy link
Contributor Author

@Kuniwak san,

Can I change Autopilot.CreateDefaultLogger method accessor to private?

@nowsprinting nowsprinting requested a review from Kuniwak May 9, 2024 21:59
@nowsprinting
Copy link
Contributor Author

Re-rename AbstractLogger to AbstractLoggerAsset (Use "Assets" instead of "Settings").

Kuniwak
Kuniwak approved these changes May 11, 2024
View reviewed changes
Copy link
Member

@Kuniwak Kuniwak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you for the contributions!

@Kuniwak Kuniwak merged commit 3569d22 into DeNA:master May 11, 2024
1 check passed
@nowsprinting nowsprinting deleted the feature/logger branch May 11, 2024 04:11
nowsprinting added a commit to nowsprinting/Anjin that referenced this pull request May 11, 2024
@nowsprinting
Fix CreateDefaultLogger method to private
1f055ca 
refs DeNA#52
@nowsprinting nowsprinting mentioned this pull request May 11, 2024
Merged
1 task
@nowsprinting nowsprinting mentioned this pull request May 11, 2024
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kuniwak Kuniwak Kuniwak approved these changes

Assignees
No one assigned
Labels
feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nowsprinting @Kuniwak