Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Dockerfile build and add GitHub action for testing it #529

Closed
2 tasks done
gcroci2 opened this issue Nov 28, 2023 · 2 comments · Fixed by #637 or #640
Closed
2 tasks done

Fix Dockerfile build and add GitHub action for testing it #529

gcroci2 opened this issue Nov 28, 2023 · 2 comments · Fixed by #637 or #640
Assignees
Labels
bug Something isn't working CI continuous integration

Comments

@gcroci2
Copy link
Collaborator

gcroci2 commented Nov 28, 2023

  • Fix Dockerfile build issue due to libstdc++.so.6 version conflict fix: dockerfile image build #637
  • Add action for testing the Dockerfile. We have two options:
    • Publishing to GitHub packages: As outlined in this guide, we could publish the Docker image to GitHub Packages and then test and update the image from the CI. We decided to go for this option (PR ci: add action for releasing new docker image and testing it #640).
    • We could also add a GitHub action to automatically build and test the Docker image whenever there's a change in the .yml environment file or pyproject.toml. See also here as an example.

When this is done, do a new software patch release.

Copy link

This issue is stale because it has been open for 30 days with no activity.

@github-actions github-actions bot added the stale issue not touched from too much time label Dec 29, 2023
@gcroci2 gcroci2 added the nice to have low priority issues label Jan 3, 2024
@gcroci2 gcroci2 removed nice to have low priority issues stale issue not touched from too much time labels Jun 27, 2024
@DaniBodor DaniBodor assigned DaniBodor and gcroci2 and unassigned DaniBodor Jul 9, 2024
@gcroci2
Copy link
Collaborator Author

gcroci2 commented Aug 2, 2024

At the moment, the Dockerfile building is broken. I am investigating what has changed.

  • In particular, I get libstdc++.so.6: version GLIBCXX_3.4.29' not found` from a scipy import, even though one of the libstdc++.so.6 folders does contain such a file (the one in the conda/ folder, not the one in the system's upper root).
  • I suspect that for some reason now the container can't detect the newest version of libstdc++.so.6 and points at an older one that does not contain the needed GLIBCXX_3.4.29.

When it will be fixed, I will try to create an action for building the docker image and testing it every time there is a change in the .yml environment file or in the pyproject.toml.

@gcroci2 gcroci2 changed the title Add GitHub Action for testing Dockerfile Fix Dockerfile build and add GitHub action for testing it Aug 2, 2024
@gcroci2 gcroci2 added the bug Something isn't working label Aug 2, 2024
@gcroci2 gcroci2 linked a pull request Aug 8, 2024 that will close this issue
@gcroci2 gcroci2 added the priority Solve this first label Aug 8, 2024
@gcroci2 gcroci2 added the blocking This issue blocks the others label Aug 8, 2024
@gcroci2 gcroci2 linked a pull request Sep 4, 2024 that will close this issue
@gcroci2 gcroci2 closed this as completed Sep 16, 2024
@gcroci2 gcroci2 removed priority Solve this first blocking This issue blocks the others labels Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working CI continuous integration
Projects
Status: Done
2 participants