Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: dockerfile image build #637

Merged
merged 1 commit into from
Sep 6, 2024
Merged

Conversation

gcroci2
Copy link
Collaborator

@gcroci2 gcroci2 commented Aug 8, 2024

While investigating issue #540, I encountered a problem with our Dockerfile build process. The root cause was a version mismatch with libstdc++.so.6, leading to the following error during a SciPy import:

libstdc++.so.6: version `GLIBCXX_3.4.29' not found
  • The error occurred because the container was incorrectly linking to an outdated version of libstdc++.so.6 from the system's root directory, rather than the newer version available in the Conda environment.
  • Although the required GLIBCXX_3.4.29 symbol was present in the Conda-managed version of libstdc++.so.6, the container failed to detect it and instead used the system's older version.

To resolve this, I made the following changes:

  • Updated the base image: I changed the base image from ubuntu:20.04 to ubuntu:22.04, which includes a more recent version of libstdc++.so.6 in the system libraries.
  • Manual Conda installation: instead of relying on the base image from Miniconda, I added the Conda installation steps directly in the Dockerfile taking inspiration from the original condaforge/miniforge3 image's Dockerfile.

These changes allow the container to correctly locate and use the updated libstdc++.so.6, resolving the build issue. Next steps are outlined in #529.

@gcroci2 gcroci2 requested a review from DaniBodor August 8, 2024 09:35
@gcroci2 gcroci2 linked an issue Aug 8, 2024 that may be closed by this pull request
2 tasks
Copy link

This PR is stale because it has been open for 14 days with no activity.

@github-actions github-actions bot added the stale issue not touched from too much time label Aug 23, 2024
@gcroci2 gcroci2 merged commit 128d5f9 into dev Sep 6, 2024
6 checks passed
@gcroci2 gcroci2 deleted the 529_fix_dockerfile_add_test_gcroci2 branch September 6, 2024 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale issue not touched from too much time
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix Dockerfile build and add GitHub action for testing it
2 participants