Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add action for releasing new docker image and testing it #640

Merged
merged 44 commits into from
Sep 16, 2024

Conversation

gcroci2
Copy link
Collaborator

@gcroci2 gcroci2 commented Sep 4, 2024

Commits are too messy to be considered, here I summarized what I did:

  • Since the instruction from GitHub for Publishing images to GitHub Packages were generating an image without manifest (that was not actually pullable), I ended up by adapting a workflow from rsd repo, that works well.
  • The release.yml file now contains also the publication of an updated docker image on GitHub Packages, that happens only when a new package release is published on PyPI. Both the release number and the latest tags are assigned to the newly published image.
  • the test-docker-image.yml file runs tests in the latest deployed image. This workflow gets triggered only when a complete release (PyPI + image on GitHub Packages) succeeds.
  • In the CI I now fixed ubuntu to 22.04.

Once this PR is merged, we need to do a new release in order to actually publish a correct version of the image. Then we will need to delete the version I published now, that had only testing purposes. I tested the new workflows during the development of the PR and everything should work as exected, but we will know for sure only when a new package release will be published.

Copy link
Collaborator Author

gcroci2 commented Sep 4, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @gcroci2 and the rest of your teammates on Graphite Graphite

@gcroci2 gcroci2 changed the title add action for releasing new docker image ci: add action for releasing new docker image and testing it Sep 4, 2024
@gcroci2 gcroci2 marked this pull request as ready for review September 4, 2024 11:49
@gcroci2 gcroci2 linked an issue Sep 4, 2024 that may be closed by this pull request
2 tasks
Base automatically changed from 529_fix_dockerfile_add_test_gcroci2 to dev September 6, 2024 09:26
Copy link
Collaborator

@DaniBodor DaniBodor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's great to have an automated up-date docker image ready to go at all times. Lots of work has gone into this, but I think it was worth it.

There are a few merge conflicts. I think due to the notebook changes. Hopefully easy to solve.

Few questions:

  • I have not tested the new install instructions yet. Are these something I can test already, or only after the workflow has triggered at least once?
  • Has the new workflow/changes to existing workflows been tested? If not, is there any way to do so before merging (without having to make a fork and release that on PyPi as well)?

.github/workflows/release.yml Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@gcroci2
Copy link
Collaborator Author

gcroci2 commented Sep 13, 2024

  • I have not tested the new install instructions yet. Are these something I can test already, or only after the workflow has triggered at least once?

During the development I tested them on this branch (by changing the settings in the yml workflow), but as it is now it can't be directly tested. I plan to do a new release as soon as this PR is merged so we can be sure it all works fine, and worst case I'll open immediately a new issue.

  • Has the new workflow/changes to existing workflows been tested? If not, is there any way to do so before merging (without having to make a fork and release that on PyPi as well)?

There is no straightforward way. I'll try now to solve the merge conflicts paying attention, but then we will know for sure only with the first real release will be triggered.

@gcroci2 gcroci2 merged commit a822861 into dev Sep 16, 2024
8 checks passed
@gcroci2 gcroci2 deleted the 529_add_docker_testing_action_gcroci2 branch September 16, 2024 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix Dockerfile build and add GitHub action for testing it
2 participants