Replace trans tags with separate trans files #83
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VirginiaDooley
force-pushed
the
hotfix/static-translations
branch
from
7c8824d
to
dc87b99
Compare
symroe
reviewed
May 14, 2024
dc_utils/templates/dc_base.html
Outdated
| @@ -44,35 +43,32 @@ | |||
| </main> | |||
| {% endblock main_base %} | |||
|
|
|||
|
|
|||
| {% if USE_I18N %} | |||
There was a problem hiding this comment.
I'm not sure this block is needed? I think Django sets LANGUAGE_CODE automaticlly if the i18n context processor is enabled. If it's not, the below if statement will fall back to the else condition.
Can you check this?
There was a problem hiding this comment.
You're right, I've removed that block.
VirginiaDooley
force-pushed
the
hotfix/static-translations
branch
from
dc87b99
to
8ef01ac
Compare
symroe
approved these changes
May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref DemocracyClub/WhoCanIVoteFor#1740 and https://app.asana.com/0/1204880927741389/1207297516776616/f
This change removes translation tags in the footer and instead uses conditionals based on language code to which footer template should be used.