Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add i18 beamline file #710

Closed
wants to merge 6 commits into from
Closed

Conversation

stan-dot
Copy link
Contributor

Fixes #709

Instructions to reviewer on how to test:

  1. `dodal connect i181
  2. Confirm thing all the listed devices connect

Checks for reviewer

  • Would the PR title make sense to a scientist on a set of release notes
  • If a new device has been added does it follow the standards
  • If changing the API for a pre-existing device, ensure that any beamlines using this device have updated their Bluesky plans accordingly
  • Have the connection tests for the relevant beamline(s) been run via dodal connect ${BEAMLINE}

@stan-dot stan-dot added enhancement New feature or request python Pull requests that update Python code i18 labels Jul 29, 2024
@stan-dot stan-dot self-assigned this Jul 29, 2024
@stan-dot stan-dot linked an issue Jul 29, 2024 that may be closed by this pull request
Copy link

codecov bot commented Jul 29, 2024

Codecov Report

Attention: Patch coverage is 85.58559% with 16 lines in your changes missing coverage. Please review.

Project coverage is 94.54%. Comparing base (9bfa98f) to head (3fc0386).
Report is 2 commits behind head on main.

Files Patch % Lines
src/dodal/devices/areadetector/adutils.py 15.38% 11 Missing ⚠️
src/dodal/devices/areadetector/adaravis.py 33.33% 2 Missing ⚠️
src/dodal/devices/areadetector/adsim.py 50.00% 1 Missing ⚠️
src/dodal/devices/i22/nxsas.py 0.00% 1 Missing ⚠️
src/dodal/devices/logging_ophyd_device.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #710      +/-   ##
==========================================
+ Coverage   94.49%   94.54%   +0.05%     
==========================================
  Files         110      111       +1     
  Lines        4376     4418      +42     
==========================================
+ Hits         4135     4177      +42     
  Misses        241      241              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stan-dot stan-dot changed the title add devices without checked pvs Add i18 beamline file Jul 29, 2024
@stan-dot stan-dot force-pushed the 709-make-i18-beamlines-repository branch from 884f963 to 3ee4bb4 Compare July 29, 2024 13:43
Relm-Arrowny and others added 5 commits July 29, 2024 15:48
* removed mockito

* add a line to covert when object is not DetectorDistanceToBeamXYConverter

* added assert to convert lookup table different
* Fix numerous pyright errors

* Fix other pyright issues (#719)

* DirectoryProvider compatibility adjustments

* Ophyd_async Pyright changes

* Ophyd Pyright changes

* d_spacing order of magnitude

* Enable full pyright checking and remove diff checking

---------

Co-authored-by: DiamondJoseph <[email protected]>
…dLightSource/dodal into 709-make-i18-beamlines-repository
@stan-dot
Copy link
Contributor Author

stan-dot commented Aug 1, 2024

01.08.2024 11:32
dodal connect $BEAMLINE
Attempting connection to i18 (using dodal.beamlines.i18)
3 devices connected :
dcm
undulator
synchrotron

and the failing devices are
it, i0, xpress3, panda1, slits_1
we could skip those latter 4 and focus on the basic step scan plan

@stan-dot
Copy link
Contributor Author

stan-dot commented Aug 1, 2024

would need to make a fresh file too, this one got mangled with the merged main changes

@stan-dot stan-dot closed this Aug 1, 2024
@stan-dot stan-dot mentioned this pull request Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request i18 python Pull requests that update Python code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make i18 - beamlines files
3 participants