-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add i18 beamline file #710
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #710 +/- ##
==========================================
+ Coverage 94.49% 94.54% +0.05%
==========================================
Files 110 111 +1
Lines 4376 4418 +42
==========================================
+ Hits 4135 4177 +42
Misses 241 241 ☔ View full report in Codecov by Sentry. |
884f963
to
3ee4bb4
Compare
* removed mockito * add a line to covert when object is not DetectorDistanceToBeamXYConverter * added assert to convert lookup table different
* Fix numerous pyright errors * Fix other pyright issues (#719) * DirectoryProvider compatibility adjustments * Ophyd_async Pyright changes * Ophyd Pyright changes * d_spacing order of magnitude * Enable full pyright checking and remove diff checking --------- Co-authored-by: DiamondJoseph <[email protected]>
…dLightSource/dodal into 709-make-i18-beamlines-repository
01.08.2024 11:32 and the failing devices are |
would need to make a fresh file too, this one got mangled with the merged main changes |
Fixes #709
Instructions to reviewer on how to test:
Checks for reviewer
dodal connect ${BEAMLINE}