Slb/ab/map layer object selection #17
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkissel
requested changes
Feb 9, 2024
src/cadenza.js
Outdated
| * Set Selection in the currently shown map view. | ||
| * | ||
| * @param {WorkbookLayerPath} layer - The data view layer to set the selection in | ||
| * @param {string[]} values - The variable values |
There was a problem hiding this comment.
string[] works for the layer selection. But to set the selection of a table view, we'd need unknown[][], right? How do would you handle that later? Automatically transform string[] to unknown[][]?
src/cadenza.js
Outdated
| /** @type string[] */ values, | ||
| ) { | ||
| this.#log('CadenzaClient#removeSelection', layer, values); | ||
| return this.#postRequest('removeSelection', { layer, values }); |
There was a problem hiding this comment.
Would it maybe make our life in Cadenza easier if we used only one event with a mode?: 'add' | 'remove'? (The API here is fine 👍)
jkissel
reviewed
Feb 13, 2024
* add getData method to get map image * add getData to changelog * refactor getData method * refactor postRequest method, display image in iframe * remove canvas * make #postRequest generic * fix formatting * fix return types of #setFilter and #setLayerVisibility --------- Co-authored-by: palys <[email protected]> Co-authored-by: kissel <[email protected]> Co-authored-by: Johannes Kissel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.