Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Slb/ab/map layer object selection #17
Slb/ab/map layer object selection #17
Changes from 3 commits
3e05d12
0c7ccb2
7649456
7acda28
e428556
1eaaafd
14bfeb2
a4cd933
ebff610
ab99f44
0648a89
6959725
9d141c0
7843ad7
adc09a6
88421b4
8bde324
e9b956a
6c8cd27
5d067e2
38a6868
1559445
2a6d384
27230ce
8fd0bd4
df48fb7
bb0aecd
4962ccc
f8cb30a
20a5518
54aef91
7fdc276
8f38b7f
36e53dd
efa51f9
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
string[]
works for the layer selection. But to set the selection of a table view, we'd needunknown[][]
, right? How do would you handle that later? Automatically transformstring[]
tounknown[][]
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it maybe make our life in Cadenza easier if we used only one event with a
mode?: 'add' | 'remove'
? (The API here is fine 👍)