Replace libdparse in VcallCtorChecker #78
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RazvanN7
reviewed
Nov 7, 2023
edi33416
force-pushed
the
replace_libdparse
branch
from
820a5a8
to
2bf728f
Compare
Closed
RazvanN7
reviewed
Mar 15, 2024
| { | ||
| class Bar | ||
| { | ||
| this() { bar(); } |
There was a problem hiding this comment.
Try calling foo here, I suspect that a warning will be issued although I don't think it should. To make sure, you should validate the behavior with what dscanner did before.
|
ping on this one. |
On hold for now. |
Vladiwostok
force-pushed
the
vcall-ctor
branch
from
a5d3575
to
bf60900
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR continues #69