Fix ci phan/phpstan notices #32779
Merged
Fix ci phan/phpstan notices #32779
+28
−25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
#32758 done some fix in branch 21 |
mdeweerd
force-pushed
the
fix/ci/2025.1.25
branch
from
f7b677d to
98ceae3
Compare
Thanks, I update the resolution in note.php to match yours, cherry picked the resolution for societeaccount, but kept a resolution in conf.class.php as I restrict the values to |
mdeweerd
force-pushed
the
fix/ci/2025.1.25
branch
3 times, most recently
from
f5b57e0 to
3d612ea
Compare
|
Fixed some new things, remaining issues need functional analysis. |
mdeweerd
force-pushed
the
fix/ci/2025.1.25
branch
from
3d612ea to
d6069d4
Compare
mdeweerd
force-pushed
the
fix/ci/2025.1.25
branch
from
140a944 to
c152dc3
Compare
# Fix ci phan/phpstan notices Fix most notices, except undefined fk_website in SocieteAccount as it is not clear if that is supposed to be a property there (more specifically, that it is set).
mdeweerd
force-pushed
the
fix/ci/2025.1.25
branch
from
c152dc3 to
2696c9a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix ci phan/phpstan notices
Fix most notices, except undefined fk_website in SocieteAccount as it is not clear if that is supposed to be a property there (more specifically, that it is set).