Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweak behaviors of build and release CI workflows #621

Merged
merged 1 commit into from
Oct 14, 2024

Conversation

altheaden
Copy link
Contributor

@altheaden altheaden commented Sep 23, 2024

Hello! With this PR I've tweaked some settings that @xylar and I have determined work out better in CI workflows on other repos. I've made the same changes here. These changes include:

  1. cancel_others is now set to false by default, which should make it easier to decipher if a bug is isolated to a specific version of python via CI
  2. All references to mamba/mambaforge have been removed and/or changed to conda and Miniforge3
  3. The timeout for the pre-commit job has been upped to 5 minutes

Updated template from @forsyth2

Issue resolution

This pull request is a minor adjustment that does not affect functional code.

1. Does this do what we want it to do?

Objectives:

  • Run CI with Miniforge3 rather than mamabforge
  • Run CI with a longer timeout for pre-commit checks, to ensure enough running time for these checks to pass.
  • cancel_others is now set to False.

Required:

  • Product Management: I have confirmed with the stakeholders that the objectives above are correct and complete.
  • Testing: I have added or modified at least one "min-case" configuration file to test this change. Every objective above is represented in at least one cfg.
  • The existing CI checks on GitHub check this.
  • Testing: I have considered likely and/or severe edge cases and have included them in testing.

2. Are the implementation details accurate & efficient?

Required:

  • Logic: I have visually inspected the entire pull request myself.

3. Is this well documented?

Required:

  • Documentation: by looking at the docs, a new user could easily understand the functionality introduced by this pull request.
    • This change does not require new documentation.

4. Is this code clean?

Required:

  • Readability: The code is as simple as possible and well-commented, such that a new team member could understand what's happening.
  • Pre-commit checks: All the pre-commits checks have passed.

@altheaden
Copy link
Contributor Author

@forsyth2 Just rebased this branch as well, can you run CI when you get a chance?

@forsyth2 forsyth2 merged commit a45d59d into E3SM-Project:main Oct 14, 2024
4 checks passed
@altheaden altheaden deleted the tweak-ci branch October 14, 2024 20:23
@xylar
Copy link
Contributor

xylar commented Oct 14, 2024

Thanks @forsyth2!

@xylar
Copy link
Contributor

xylar commented Oct 14, 2024

Thanks again @altheaden for making these updates.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants