Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweak behaviors of build and release CI workflows #352

Merged
merged 1 commit into from
Sep 27, 2024

Conversation

altheaden
Copy link
Contributor

@altheaden altheaden commented Sep 23, 2024

Hello! With this PR I've tweaked some settings that @xylar and I have determined work out better in CI workflows on other repos. I've made the same changes here. These changes include:

  1. All references to mamba/mambaforge have been removed and/or changed to conda and Miniforge3
  2. The timeout for the pre-commit job has been upped to 5 minutes

Updated template from @forsyth2:

Issue resolution

This pull request is a minor adjustment that does not affect functional code.

1. Does this do what we want it to do?

Objectives:

  • Run CI with Miniforge3 rather than mamabforge
  • Run CI with a longer timeout for pre-commit checks, to ensure enough running time for these checks to pass.
  • [Note: the cancel_others change present in the equivalent pull requests is not needed here, since here that parameter isn't in the file to begin with.]

Required:

  • Product Management: I have confirmed with the stakeholders that the objectives above are correct and complete.
  • Testing: I have added at least one automated test. Every objective above is represented in at least one test.
    • The existing CI checks on GitHub check this.
  • Testing: I have considered likely and/or severe edge cases and have included them in testing.

2. Are the implementation details accurate & efficient?

Required:

  • Logic: I have visually inspected the entire pull request myself.

3. Is this well documented?

Required:

  • Documentation: by looking at the docs, a new user could easily understand the functionality introduced by this pull request.
  • This change does not require new documentation.

4. Is this code clean?

Required:

  • Readability: The code is as simple as possible and well-commented, such that a new team member could understand what's happening.
  • Pre-commit checks: All the pre-commits checks have passed.

@xylar xylar mentioned this pull request Sep 23, 2024
7 tasks
@forsyth2
Copy link
Collaborator

I have inspected the code visually. I will merge this change. Thanks @altheaden.

@forsyth2 forsyth2 merged commit ef8372a into E3SM-Project:main Sep 27, 2024
3 checks passed
@xylar
Copy link
Contributor

xylar commented Sep 28, 2024

Thanks @forsyth2!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants