Improve office world #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
francocipollone
requested changes
Aug 20, 2024
|
Before merging try to fix DCO: https://github.com/src-d/guide/blob/master/developer-community/fix-DCO.md for the commits. |
francocipollone
previously approved these changes
Aug 22, 2024
|
Given that you are going to modify a bit the wooden floor, can you check that actually the wooden hallway should be a bit shorter: For example You can see this in this videos as well click here for video |
Signed-off-by: Laura Rodriguez <[email protected]>
Signed-off-by: Laura Rodriguez <[email protected]>
Signed-off-by: Laura Rodriguez <[email protected]>
Signed-off-by: Laura Rodriguez <[email protected]>
Signed-off-by: Franco Cipollone <[email protected]> Signed-off-by: Laura Rodriguez <[email protected]>
larodriguez22
force-pushed
the
larodriguez22/improve_office_world
branch
from
d63ffb9
to
c84c49b
Compare
Fixed |
Merged
Signed-off-by: Laura Rodriguez <[email protected]> Signed-off-by: Franco Cipollone <[email protected]> Co-authored-by: Franco Cipollone <[email protected]> Signed-off-by: Franco Cipollone <[email protected]>
francocipollone
force-pushed
the
larodriguez22/improve_office_world
branch
from
d539b96
to
64d4387
Compare
Signed-off-by: Franco Cipollone <[email protected]>
Signed-off-by: Franco Cipollone <[email protected]>
Voldivh
approved these changes
Aug 26, 2024
There was a problem hiding this comment.
LGTM! Awesome job, we needed to make some changes to the andino_rmf repo, we should try to merge this PR and Ekumen-OS/andino_rmf#27 at the same time.
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎉 New feature
Related to #60
Summary
Improvement of office world by using blender and pbr textures.
Screencast.from.08-19-2024.05.09.46.PM.webm
Test it
To run: