Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add NDT AMCL 3D node. #422

Merged
merged 2 commits into from
Aug 16, 2024
Merged

Add NDT AMCL 3D node. #422

merged 2 commits into from
Aug 16, 2024

Conversation

serraramiro1
Copy link
Contributor

@serraramiro1 serraramiro1 commented Aug 8, 2024

Proposed changes

Adds a new node for 3D NDT AMCL.
Closes #422
Closes #311
Closes #313

Type of change

  • 🐛 Bugfix (change which fixes an issue)
  • 🚀 Feature (change which adds functionality)
  • 📚 Documentation (change which fixes or extends documentation)

Checklist

Put an x in the boxes that apply. This is simply a reminder of what we will require before merging your code.

  • Lint and unit tests (if any) pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • All commits have been signed for DCO

@serraramiro1
Copy link
Contributor Author

@hidmic ready for a first pass.
Also, this seems to not work on Jazzy, I'll TAL in the meantime.

I'll try to bring the coverage for the node a little bit higher.

@serraramiro1 serraramiro1 added enhancement New feature or request cpp Related to C++ code ros Related to ROS labels Aug 12, 2024
@serraramiro1
Copy link
Contributor Author

Running jazzy's container is giving me :

developer@23e2d3be126e:/ws$ colcon build --symlink-install --packages-up-to=beluga_amcl
Starting >>> beluga
--- stderr: beluga
CMake Error at test/CMakeLists.txt:30 (find_package):
  By not providing "Findbenchmark.cmake" in CMAKE_MODULE_PATH this project
  has asked CMake to find a package configuration file provided by
  "benchmark", but CMake did not find one.

  Could not find a package configuration file provided by "benchmark" with
  any of the following names:

    benchmarkConfig.cmake
    benchmark-config.cmake

  Add the installation prefix of "benchmark" to CMAKE_PREFIX_PATH or set
  "benchmark_DIR" to a directory containing one of the above files.  If
  "benchmark" provides a separate development package or SDK, be sure it has
  been installed.


---
Failed   <<< beluga [1.02s, exited with code 1]

Summary: 0 packages finished [1.19s]
  1 package failed: beluga
  1 package had stderr output: beluga
  2 packages not processed

Possibly related to #421 @hidmic do you think you can try to repro? I checked out main and getting the same

Copy link
Collaborator

@hidmic hidmic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First pass, great work.

beluga_amcl/include/beluga_amcl/ndt_amcl_node_3d.hpp Outdated Show resolved Hide resolved
beluga_amcl/src/ndt_amcl_node_3d.cpp Outdated Show resolved Hide resolved
beluga_amcl/src/ndt_amcl_node_3d.cpp Outdated Show resolved Hide resolved
beluga_amcl/src/ndt_amcl_node_3d.cpp Outdated Show resolved Hide resolved
beluga_amcl/src/ndt_amcl_node_3d.cpp Outdated Show resolved Hide resolved
beluga_amcl/src/ndt_amcl_node_3d.cpp Outdated Show resolved Hide resolved
beluga_amcl/src/ndt_amcl_node_3d.cpp Outdated Show resolved Hide resolved
beluga_amcl/test/test_ndt_amcl_3d_node.cpp Outdated Show resolved Hide resolved
@serraramiro1 serraramiro1 changed the title [WIP] Add NDT AMCL 3D node. Add NDT AMCL 3D node. Aug 13, 2024
Copy link
Collaborator

@hidmic hidmic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Second pass!

beluga/include/beluga/policies/on_motion.hpp Outdated Show resolved Hide resolved
beluga_amcl/cmake/ament.cmake Outdated Show resolved Hide resolved
beluga_amcl/include/beluga_amcl/ndt_amcl_node_3d.hpp Outdated Show resolved Hide resolved
beluga_amcl/include/beluga_amcl/ndt_amcl_node_3d.hpp Outdated Show resolved Hide resolved
beluga_amcl/package.xml Outdated Show resolved Hide resolved
beluga_amcl/src/ndt_amcl_node_3d.cpp Show resolved Hide resolved
beluga_amcl/src/ndt_amcl_node_3d.cpp Outdated Show resolved Hide resolved
beluga_amcl/src/ndt_amcl_node_3d.cpp Show resolved Hide resolved
Copy link
Collaborator

@hidmic hidmic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How can I give this a shot locally @serraramiro1?

beluga_amcl/src/ndt_amcl_node_3d.cpp Show resolved Hide resolved
beluga_ros/include/beluga_ros/tf2_sophus.hpp Outdated Show resolved Hide resolved
Signed-off-by: Ramiro Serra <[email protected]>
Signed-off-by: Ramiro Serra <[email protected]>
@serraramiro1
Copy link
Contributor Author

How can I give this a shot locally @serraramiro1?

Try with the dataset and map I shared locally, and use:

Replace arguments to match your local env

ros2 launch beluga_example ndt_replay_3d.launch.xml localization_ndt_map:=/ws/src/beluga/1m_map.hdf5 bag_path:=/ws/src/beluga/rosbag2_2024_08_01-12_53_07

Copy link
Collaborator

@hidmic hidmic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Proof of life working

@serraramiro1 serraramiro1 merged commit d96a927 into main Aug 16, 2024
11 checks passed
@serraramiro1 serraramiro1 deleted the ramiro/ndt-3d branch August 16, 2024 14:59
This was referenced Aug 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cpp Related to C++ code enhancement New feature or request ros Related to ROS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement 3D NDT-MCL ROS 2 node Implement nD-NDT sensor model in Beluga
2 participants