-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add NDT AMCL 3D node. #422
Conversation
bc591b4
to
037cf3c
Compare
@hidmic ready for a first pass. I'll try to bring the coverage for the node a little bit higher. |
Running jazzy's container is giving me :
Possibly related to #421 @hidmic do you think you can try to repro? I checked out |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First pass, great work.
2456160
to
d12f79e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Second pass!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How can I give this a shot locally @serraramiro1?
Signed-off-by: Ramiro Serra <[email protected]>
2332c90
to
0100215
Compare
Signed-off-by: Ramiro Serra <[email protected]>
Try with the dataset and map I shared locally, and use: Replace arguments to match your local env
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Proof of life working
Proposed changes
Adds a new node for 3D NDT AMCL.
Closes #422
Closes #311
Closes #313
Type of change
Checklist
Put an
x
in the boxes that apply. This is simply a reminder of what we will require before merging your code.