Fixed #158(scrollbar issue) #309

StellarSand · 2023-06-29T13:58:35Z

Fixed Problem with scrollbar #158
I've added // TODO comments in ThemeDialogFragment and ExodusApplication classes, so you can get the checked item value from preference and set it there.

Jean-BaptisteC

Great job :)

Please fix linter
About scrollbar issue, add android:layout_marginBottom="80dp" in

StellarSand · 2023-06-29T17:05:59Z

Done. ✔️
P.S: mind if I replace relative layout elements with the better constraint layouts?

Jean-BaptisteC · 2023-06-29T17:16:04Z

P.S: mind if I replace relative layout elements with the better constraint layouts?

Ok to improve layout but this changes have an impact on differents configurations layouts ?
Because we have planned to add a new layout for tablet #296

StellarSand · 2023-06-29T17:25:16Z

Just like the fragment_about.xml we can add multiple different layouts,

one normal for portrait mode
another in res/layout-w600dp (For 7” tablets, 600dp)
another in res/layout-w720dp (For 10” tablets 720dp)
and so on?

Jean-BaptisteC · 2023-06-29T17:28:20Z

Ok, but add screenshots foreach config to see difference

StellarSand · 2023-06-29T17:34:09Z

There won't be any changes visually. UI will remain as it is right now. Just changes in xml layouts code. Later when we add multiple layouts for tablets, things can be re-arranged for tablet specific views like you showed in the screenshot in #296

Jean-BaptisteC · 2023-06-29T18:35:49Z

Ok, go on

StellarSand · 2023-06-29T21:43:41Z

Done. All nested layouts have been flattened.

Jean-BaptisteC · 2023-06-30T04:26:57Z

Please reduce space between elements in App Fragment (Same space as app in trackerdetails Fragment
Sub permission Fragment is broken, exodus show only 10 permissions, and can you reduce space between elements
Percentage bar in tracker Fragment is broken, when percentage is 100%, bar is cut at the right of the screen

StellarSand · 2023-06-30T10:51:11Z

Please reduce space between elements in App Fragment

Done

Sub permission Fragment is broken, exodus show only 10 permissions, and can you reduce space between elements

Hmm, for me it started showing 11 items. couldn't figure out why, so reverted this back to relative layout.

Percentage bar in tracker Fragment is broken, when percentage is 100%, bar is cut at the right of the screen

In android studio the layout is being rendered correctly. I already added marginEnd=30dp and it showed ample amount of space on the right. Didn't even reach the > on the right. But when testing on device, progressbar doesn't seem to respect margin values. So reverting this layout too.

Jean-BaptisteC · 2023-06-30T17:33:44Z

Reduce space between appAVTV and appAnalyzedVersionTV in app_details_fragment
Please check com.google.android.material.imageview.ShapeableImageView in recycler view app item and fragment app details, apps icon are cut in somes cases

I have start tests on theming:

Can you add checkbox or switch to enable OLED mode on comptatible devices ?
Change theming doesn't work on android 5.0

StellarSand · 2023-06-30T18:34:35Z

Reduce space between appAVTV and appAnalyzedVersionTV in app_details_fragment

Please check com.google.android.material.imageview.ShapeableImageView in recycler view app item and fragment app details, apps icon are cut in somes cases

fixed

Jean-BaptisteC · 2023-06-30T20:45:40Z

Layout looks good

StellarSand · 2023-06-30T21:42:41Z

Can you add checkbox or switch to enable OLED mode on comptatible devices ?

Unfortunately, I don't know how to. Since there is no inbuilt method for this, we probably have to define a custom style with all the colors (background, status bar, nav bar, fab everything). When user selects checkbox/switch we'd have to set the theme/style to our custom oled style. When user unchecks, we'd again set it back to base theme. That's the idea at least, but last time I tried this, it didn't work, so 🤷

Change theming doesn't work on android 5.0

Maybe we show the theme option only for sdk > 21? 🤔
According to #283 support for sdk 21 & 22 will be dropped soon any way.

Jean-BaptisteC · 2023-07-01T05:41:25Z

I have check on others Android apps, to detect OLED mode, apps check configuration -> https://developer.android.com/develop/ui/views/theming/darktheme#java
For OLED theme, apply dark theme with black background (not need create a new style)

I used apps with dark theme in API 21 (NewPipe, Organic Maps, VLC), i think it's doesn't work because, we don't have Base.V21 Theme in our styles

StellarSand · 2023-07-01T13:45:37Z

For OLED theme, apply dark theme with black background (not need create a new style)

we don't have Base.V21 Theme in our styles

okay it's done. You can do the // TODO stuff and it will be fully working.

Jean-BaptisteC · 2023-07-05T19:12:52Z

I'm not a developer, i try to maintain project but i'm not expert.
I can give you somes help to finish Theme option.
Can you create separate PR to theme option, i want merge scrollbar fix.

I have noticed somes things, on theme option:

Android top bar and bottom bar doesn't respect colorPrimary in Android 21
I we want add oled mode, you need to add OK button to validate selection

StellarSand · 2023-07-06T10:31:59Z

Can you create separate PR to theme option, i want merge scrollbar fix.

Yeah sure no problem. :)

* I we want add oled mode, you need to add `OK` button to validate selection

Why 🤔 You just check the checkbox and it switches to OLED mode directly and vice versa.

Jean-BaptisteC · 2023-07-06T10:51:08Z

On other app, to enable oled mode, we need to select dark mode before enable oled

StellarSand · 2023-07-06T11:15:44Z

Yeah same here too. The OLED mode will only be enabled if dark mode is selected, or if it's follow system and the system theme is dark mode. I've handled that part already. All that remains is the // TODO stuff to set the checked values in preferences.

Jean-BaptisteC · 2023-07-12T04:44:56Z

In somes cases, if i want enable OLED mode.
I select dark mode in pop-up -> pop-up is closed
I need to re-open pop-up to select OLED mode.

StellarSand · 2023-07-13T10:22:06Z

Hmm, okay I'll do it when I split the theme stuff into a new pull request. Will do in a couple of days.

StellarSand · 2023-08-01T15:47:22Z

Reverted theme stuff so it now only has scrollbar fixes and layout changes.
Here's the separate theme PR: #321

Jean-BaptisteC · 2023-08-04T10:10:41Z

Thanks, can you remove commits about theming ?

Bumps [org.jetbrains.kotlinx:kotlinx-coroutines-android](https://github.com/Kotlin/kotlinx.coroutines) from 1.7.1 to 1.7.2. - [Release notes](https://github.com/Kotlin/kotlinx.coroutines/releases) - [Changelog](https://github.com/Kotlin/kotlinx.coroutines/blob/master/CHANGES.md) - [Commits](Kotlin/kotlinx.coroutines@1.7.1...1.7.2) --- updated-dependencies: - dependency-name: org.jetbrains.kotlinx:kotlinx-coroutines-android dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

#311) Bumps [org.jetbrains.kotlinx:kotlinx-coroutines-test](https://github.com/Kotlin/kotlinx.coroutines) from 1.7.1 to 1.7.2. - [Release notes](https://github.com/Kotlin/kotlinx.coroutines/releases) - [Changelog](https://github.com/Kotlin/kotlinx.coroutines/blob/master/CHANGES.md) - [Commits](Kotlin/kotlinx.coroutines@1.7.1...1.7.2) --- updated-dependencies: - dependency-name: org.jetbrains.kotlinx:kotlinx-coroutines-test dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Jean-Baptiste <[email protected]>

Bumps `hilt_version` from 2.46.1 to 2.47. Updates `com.google.dagger:hilt-compiler` from 2.46.1 to 2.47 - [Release notes](https://github.com/google/dagger/releases) - [Changelog](https://github.com/google/dagger/blob/master/CHANGELOG.md) - [Commits](google/dagger@dagger-2.46.1...dagger-2.47) Updates `com.google.dagger:hilt-android` from 2.46.1 to 2.47 - [Release notes](https://github.com/google/dagger/releases) - [Changelog](https://github.com/google/dagger/blob/master/CHANGELOG.md) - [Commits](google/dagger@dagger-2.46.1...dagger-2.47) --- updated-dependencies: - dependency-name: com.google.dagger:hilt-compiler dependency-type: direct:production update-type: version-update:semver-minor - dependency-name: com.google.dagger:hilt-android dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Bumps [com.google.dagger.hilt.android](https://github.com/google/dagger) from 2.46.1 to 2.47. - [Release notes](https://github.com/google/dagger/releases) - [Changelog](https://github.com/google/dagger/blob/master/CHANGELOG.md) - [Commits](google/dagger@dagger-2.46.1...dagger-2.47) --- updated-dependencies: - dependency-name: com.google.dagger.hilt.android dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Jean-Baptiste <[email protected]>

Bumps [com.google.dagger:hilt-android-testing](https://github.com/google/dagger) from 2.46.1 to 2.47. - [Release notes](https://github.com/google/dagger/releases) - [Changelog](https://github.com/google/dagger/blob/master/CHANGELOG.md) - [Commits](google/dagger@dagger-2.46.1...dagger-2.47) --- updated-dependencies: - dependency-name: com.google.dagger:hilt-android-testing dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Jean-Baptiste <[email protected]>

#320) Bumps [org.jetbrains.kotlinx:kotlinx-coroutines-test](https://github.com/Kotlin/kotlinx.coroutines) from 1.7.2 to 1.7.3. - [Release notes](https://github.com/Kotlin/kotlinx.coroutines/releases) - [Changelog](https://github.com/Kotlin/kotlinx.coroutines/blob/master/CHANGES.md) - [Commits](https://github.com/Kotlin/kotlinx.coroutines/commits) --- updated-dependencies: - dependency-name: org.jetbrains.kotlinx:kotlinx-coroutines-test dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Bumps [org.jetbrains.kotlinx:kotlinx-coroutines-android](https://github.com/Kotlin/kotlinx.coroutines) from 1.7.2 to 1.7.3. - [Release notes](https://github.com/Kotlin/kotlinx.coroutines/releases) - [Changelog](https://github.com/Kotlin/kotlinx.coroutines/blob/master/CHANGES.md) - [Commits](https://github.com/Kotlin/kotlinx.coroutines/commits) --- updated-dependencies: - dependency-name: org.jetbrains.kotlinx:kotlinx-coroutines-android dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

StellarSand · 2023-08-04T11:29:17Z

okay I'm pretty sure I removed the correct commits relating to theme. Please check & confirm.

Jean-BaptisteC

✅ Pixel 6 - Android 13

fixed #158

22c71c4

Jean-BaptisteC suggested changes Jun 29, 2023

View reviewed changes

StellarSand requested a review from Jean-BaptisteC June 29, 2023 17:15

StellarSand mentioned this pull request Aug 1, 2023

Fixes #239(Theme option) #321

Closed

StellarSand added 2 commits August 4, 2023 16:50

fixed margin bottom

d8e13ed

constraint layout

b8492b1

StellarSand and others added 11 commits August 4, 2023 16:50

reverted a_d_perms & rv_tracker_item layouts

0892e43

fixed icon cropping

74f7222

fixed icon cropping_2

0560b63

Merge branch 'master' into master

20c85b5

StellarSand changed the title ~~Fixed #158(scrollbar issue) and #239(Theme option)~~ Fixed #158(scrollbar issue) Aug 4, 2023

Jean-BaptisteC approved these changes Aug 4, 2023

View reviewed changes

Jean-BaptisteC merged commit 6251bb6 into Exodus-Privacy:master Aug 4, 2023
1 check passed

Jean-BaptisteC mentioned this pull request Feb 19, 2024

Fix tracker detail fragment layout #406

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fixed #158(scrollbar issue) #309

Fixed #158(scrollbar issue) #309

StellarSand commented Jun 29, 2023 •

edited by Jean-BaptisteC

Loading

Jean-BaptisteC left a comment

StellarSand commented Jun 29, 2023

Jean-BaptisteC commented Jun 29, 2023

StellarSand commented Jun 29, 2023

Jean-BaptisteC commented Jun 29, 2023

StellarSand commented Jun 29, 2023

Jean-BaptisteC commented Jun 29, 2023

StellarSand commented Jun 29, 2023

Jean-BaptisteC commented Jun 30, 2023

StellarSand commented Jun 30, 2023

Jean-BaptisteC commented Jun 30, 2023

StellarSand commented Jun 30, 2023 •

edited

Loading

Jean-BaptisteC commented Jun 30, 2023

StellarSand commented Jun 30, 2023 •

edited

Loading

Jean-BaptisteC commented Jul 1, 2023 •

edited

Loading

StellarSand commented Jul 1, 2023 •

edited

Loading

Jean-BaptisteC commented Jul 5, 2023

StellarSand commented Jul 6, 2023

Jean-BaptisteC commented Jul 6, 2023

StellarSand commented Jul 6, 2023 •

edited

Loading

Jean-BaptisteC commented Jul 12, 2023

StellarSand commented Jul 13, 2023

StellarSand commented Aug 1, 2023

Jean-BaptisteC commented Aug 4, 2023

StellarSand commented Aug 4, 2023

Jean-BaptisteC left a comment

Fixed #158(scrollbar issue) #309

Fixed #158(scrollbar issue) #309

Conversation

StellarSand commented Jun 29, 2023 • edited by Jean-BaptisteC Loading

Jean-BaptisteC left a comment

Choose a reason for hiding this comment

StellarSand commented Jun 29, 2023

Jean-BaptisteC commented Jun 29, 2023

StellarSand commented Jun 29, 2023

Jean-BaptisteC commented Jun 29, 2023

StellarSand commented Jun 29, 2023

Jean-BaptisteC commented Jun 29, 2023

StellarSand commented Jun 29, 2023

Jean-BaptisteC commented Jun 30, 2023

StellarSand commented Jun 30, 2023

Jean-BaptisteC commented Jun 30, 2023

StellarSand commented Jun 30, 2023 • edited Loading

Jean-BaptisteC commented Jun 30, 2023

StellarSand commented Jun 30, 2023 • edited Loading

Jean-BaptisteC commented Jul 1, 2023 • edited Loading

StellarSand commented Jul 1, 2023 • edited Loading

Jean-BaptisteC commented Jul 5, 2023

StellarSand commented Jul 6, 2023

Jean-BaptisteC commented Jul 6, 2023

StellarSand commented Jul 6, 2023 • edited Loading

Jean-BaptisteC commented Jul 12, 2023

StellarSand commented Jul 13, 2023

StellarSand commented Aug 1, 2023

Jean-BaptisteC commented Aug 4, 2023

StellarSand commented Aug 4, 2023

Jean-BaptisteC left a comment

Choose a reason for hiding this comment

StellarSand commented Jun 29, 2023 •

edited by Jean-BaptisteC

Loading

StellarSand commented Jun 30, 2023 •

edited

Loading

StellarSand commented Jun 30, 2023 •

edited

Loading

Jean-BaptisteC commented Jul 1, 2023 •

edited

Loading

StellarSand commented Jul 1, 2023 •

edited

Loading

StellarSand commented Jul 6, 2023 •

edited

Loading