-
-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #239(Theme option) #321
Conversation
Did you have need help to continue PR ? |
Hi. I was little busy with other things and hence could not continue. I will implement the checkbox tomorrow. If all works well there's no need to drop support for API 21 & 22. If not, we'll think about it later. I guess the only help needed is implementing preferences wherever I've added |
Ok, I suggest to add |
# Conflicts: # app/src/main/java/org/eu/exodus_privacy/exodusprivacy/MainActivity.kt # app/src/main/res/values/styles.xml
Switch ✔️ |
To implement preferences, you can find more information here I think to start implementation, you need to add a new default value here: Line 33 in 78f5d38
To check value, you can check this function exodus-android-app/app/src/main/java/org/eu/exodus_privacy/exodusprivacy/MainActivity.kt Line 97 in 78f5d38
To update value, you can check this exodus-android-app/app/src/main/java/org/eu/exodus_privacy/exodusprivacy/MainActivityViewModel.kt Line 27 in 78f5d38
|
Is it easier for you, if we use android x preference? |
Hello. I've been very busy and unwell recently. I'll take a look at this once I recover soon. |
Tried my best, but no luck. Closing it down with a classic "skill issue." If someone else feels up to it, they can handle the preferences stuff. |
As discussed in #309 splitting theme into a separate PR. Haven't added checkbox yet.