Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #239(Theme option) #321

Closed
wants to merge 4 commits into from
Closed

Fixes #239(Theme option) #321

wants to merge 4 commits into from

Conversation

StellarSand
Copy link
Contributor

As discussed in #309 splitting theme into a separate PR. Haven't added checkbox yet.

@StellarSand StellarSand changed the title split theme stuff to this branch Fixes #239(Theme option) Aug 1, 2023
@Jean-BaptisteC
Copy link
Contributor

Jean-BaptisteC commented Aug 7, 2023

Did you have need help to continue PR ?
Is it more easy for you, if we drop API 21 and API 22 support ?

@StellarSand
Copy link
Contributor Author

Hi. I was little busy with other things and hence could not continue. I will implement the checkbox tomorrow. If all works well there's no need to drop support for API 21 & 22. If not, we'll think about it later. I guess the only help needed is implementing preferences wherever I've added TODO comments. Will let you know after I try tomorrow.

@Jean-BaptisteC
Copy link
Contributor

Jean-BaptisteC commented Aug 8, 2023

Ok,
To implement preferences, you can check PR #273
I think switch is better to enable OLED mode
https://m3.material.io/components/switch/overview
Do you think, it's possible to add switch in pop-up ?

I suggest to add app:showAsAction="ifRoom" attributes in about_menu.xml and this icon https://fonts.google.com/icons?selected=Material%20Symbols%20Outlined%3Apalette%3AFILL%400%3Bwght%40400%3BGRAD%400%3Bopsz%4048

# Conflicts:
#	app/src/main/java/org/eu/exodus_privacy/exodusprivacy/MainActivity.kt
#	app/src/main/res/values/styles.xml
@StellarSand StellarSand reopened this Aug 18, 2023
@StellarSand
Copy link
Contributor Author

StellarSand commented Aug 18, 2023

Switch ✔️
OK button ✔️
Icon ✔️
Preferences ❌

@Jean-BaptisteC
Copy link
Contributor

To implement preferences, you can find more information here
https://developer.android.com/topic/libraries/architecture/datastore
https://medium.com/androiddevelopers/datastore-and-dependency-injection-ea32b95704e3

I think to start implementation, you need to add a new default value here:

To check value, you can check this function

To update value, you can check this

fun saveNotificationPermissionRequested(status: Boolean) {

@Jean-BaptisteC
Copy link
Contributor

Is it easier for you, if we use android x preference?

@StellarSand
Copy link
Contributor Author

Hello. I've been very busy and unwell recently. I'll take a look at this once I recover soon.

@StellarSand
Copy link
Contributor Author

Tried my best, but no luck. Closing it down with a classic "skill issue." If someone else feels up to it, they can handle the preferences stuff.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants